Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[go1.16] Update to go1.16.4 #101811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2021
Merged

[go1.16] Update to go1.16.4 #101811

merged 1 commit into from
May 7, 2021

Conversation

justaugustus
Copy link
Member

What type of PR is this?

/kind feature
/area dependency release-eng release-eng/security security

What this PR does / why we need it:

Cherry pick of #101809.
Update Kubernetes to go1.16.4

Tracking issue: kubernetes/release#2060

Signed-off-by: Stephen Augustus [email protected]

/assign @dims @liggitt
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with Golang 1.16.4

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@justaugustus
[go1.16] Update to go1.16.4
b4bed15 
Signed-off-by: Stephen Augustus <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject labels May 7, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: The label(s) area/release-eng/security cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this?

/kind feature
/area dependency release-eng release-eng/security security

What this PR does / why we need it:

Cherry pick of #101809.
Update Kubernetes to go1.16.4

Tracking issue: kubernetes/release#2060

Signed-off-by: Stephen Augustus [email protected]

/assign @dims @liggitt
cc: @kubernetes/release-engineering

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubernetes is now built with Golang 1.16.4

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added area/security do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 7, 2021
@k8s-ci-robot
Copy link
Contributor

@justaugustus: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 7, 2021
@justaugustus justaugustus changed the base branch from master to release-1.21 May 7, 2021 21:04
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. area/provider/gcp Issues or PRs related to gcp provider area/test sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 7, 2021
@justaugustus
Copy link
Member Author

/hold for #101809 to merge

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2021
@k8s-ci-robot k8s-ci-robot removed the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 7, 2021
@liggitt
Copy link
Member

liggitt commented May 7, 2021

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2021
@justaugustus
Copy link
Member Author

/test pull-kubernetes-conformance-image-test
/test pull-kubernetes-e2e-gce-csi-serial
/test pull-kubernetes-e2e-gce-storage-slow
/test pull-kubernetes-e2e-gce-storage-snapshot
/test pull-kubernetes-e2e-ubuntu-gce-network-policies
/test pull-kubernetes-local-e2e

@k8s-ci-robot
Copy link
Contributor

@justaugustus: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test pull-kubernetes-e2e-kops-aws
  • /test pull-kubernetes-e2e-gce
  • /test pull-kubernetes-e2e-gce-canary
  • /test pull-kubernetes-e2e-gce-ubuntu
  • /test pull-kubernetes-e2e-gce-ubuntu-containerd
  • /test pull-kubernetes-e2e-gce-ubuntu-containerd-canary
  • /test pull-kubernetes-e2e-gce-device-plugin-gpu
  • /test pull-kubernetes-node-e2e
  • /test pull-kubernetes-node-e2e-podutil
  • /test pull-kubernetes-e2e-containerd-gce
  • /test pull-kubernetes-e2e-gce-100-performance
  • /test pull-kubernetes-kubemark-e2e-gce-big
  • /test pull-kubernetes-dependencies
  • /test pull-kubernetes-dependencies-go-canary
  • /test pull-kubernetes-files-remake
  • /test pull-kubernetes-integration
  • /test pull-kubernetes-integration-go-canary
  • /test pull-kubernetes-e2e-kind
  • /test pull-kubernetes-typecheck
  • /test pull-kubernetes-verify
  • /test pull-kubernetes-verify-go-canary
  • /test pull-kubernetes-verify-govet-levee
  • /test pull-kubernetes-conformance-kind-ipv6-parallel
  • /test pull-kubernetes-e2e-kind-ipv6
  • /test pull-kubernetes-conformance-kind-ga-only-parallel
  • /test pull-kubernetes-unit
  • /test pull-kubernetes-e2e-gce-no-stage
  • /test pull-kubernetes-cross
  • /test pull-kubernetes-bazel-build-canary
  • /test pull-kubernetes-bazel-test-canary
  • /test pull-kubernetes-bazel-test-integration-canary
  • /test pull-publishing-bot-validate
  • /test pull-kubernetes-e2e-aks-engine-windows-dockershim
  • /test pull-kubernetes-e2e-aks-engine-windows-containerd
  • /test pull-kubernetes-e2e-aks-engine-azure-disk-windows-dockershim
  • /test pull-kubernetes-e2e-aks-engine-azure-file-windows-dockershim
  • /test pull-kubernetes-e2e-aks-engine-conformance
  • /test pull-kubernetes-e2e-aks-engine-azure-disk-vmas
  • /test pull-kubernetes-e2e-aks-engine-azure-disk-vmss
  • /test pull-kubernetes-e2e-aks-engine-azure-file
  • /test pull-kubernetes-e2e-capz-conformance
  • /test pull-kubernetes-e2e-capz-ha-control-plane
  • /test pull-kubernetes-e2e-gce-network-proxy-http-connect
  • /test pull-kubernetes-e2e-gce-network-proxy-grpc
  • /test pull-kubernetes-e2e-gci-gce-autoscaling
  • /test pull-kubernetes-e2e-kind-dual-canary
  • /test pull-kubernetes-e2e-kind-ipvs-dual-canary
  • /test pull-kubernetes-e2e-gci-gce-ipvs
  • /test pull-kubernetes-e2e-gce-correctness

Use /test all to run the following jobs:

  • pull-kubernetes-e2e-gce-ubuntu-containerd
  • pull-kubernetes-node-e2e
  • pull-kubernetes-e2e-gce-100-performance
  • pull-kubernetes-dependencies
  • pull-kubernetes-integration
  • pull-kubernetes-e2e-kind
  • pull-kubernetes-typecheck
  • pull-kubernetes-verify
  • pull-kubernetes-verify-govet-levee
  • pull-kubernetes-conformance-kind-ipv6-parallel
  • pull-kubernetes-e2e-kind-ipv6
  • pull-kubernetes-conformance-kind-ga-only-parallel
  • pull-kubernetes-unit
  • pull-publishing-bot-validate

In response to this:

/test pull-kubernetes-conformance-image-test
/test pull-kubernetes-e2e-gce-csi-serial
/test pull-kubernetes-e2e-gce-storage-slow
/test pull-kubernetes-e2e-gce-storage-snapshot
/test pull-kubernetes-e2e-ubuntu-gce-network-policies
/test pull-kubernetes-local-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member Author

Ahhh, these are likely jobs only on the master branch.

Let's try to clear the contexts...
/skip pull-kubernetes-conformance-image-test
/skip pull-kubernetes-e2e-gce-csi-serial
/skip pull-kubernetes-e2e-gce-storage-slow
/skip pull-kubernetes-e2e-gce-storage-snapshot
/skip pull-kubernetes-e2e-ubuntu-gce-network-policies
/skip pull-kubernetes-local-e2e

@justaugustus
Copy link
Member Author

grumbles

@justaugustus justaugustus reopened this May 7, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label May 7, 2021
@justaugustus
Copy link
Member Author

Override for the non-existent jobs? 🤔

/override pull-kubernetes-conformance-image-test
/override pull-kubernetes-e2e-gce-csi-serial
/override pull-kubernetes-e2e-gce-storage-slow
/override pull-kubernetes-e2e-gce-storage-snapshot
/override pull-kubernetes-e2e-ubuntu-gce-network-policies
/override pull-kubernetes-local-e2e

@k8s-ci-robot
Copy link
Contributor

@justaugustus: Overrode contexts on behalf of justaugustus: pull-kubernetes-conformance-image-test, pull-kubernetes-e2e-gce-csi-serial, pull-kubernetes-e2e-gce-storage-slow, pull-kubernetes-e2e-gce-storage-snapshot, pull-kubernetes-e2e-ubuntu-gce-network-policies, pull-kubernetes-local-e2e

In response to this:

Override for the non-existent jobs? 🤔

/override pull-kubernetes-conformance-image-test
/override pull-kubernetes-e2e-gce-csi-serial
/override pull-kubernetes-e2e-gce-storage-slow
/override pull-kubernetes-e2e-gce-storage-snapshot
/override pull-kubernetes-e2e-ubuntu-gce-network-policies
/override pull-kubernetes-local-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@justaugustus
Copy link
Member Author

justaugustus commented May 7, 2021 •
edited
Loading

/retest
(Thank you for coming to my TED talk on how not to open a cherry pick)

@dims
Copy link
Member

dims commented May 7, 2021

/approve
/lgtm

It's been a looong week for you @justaugustus :)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, justaugustus, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@puerco
Copy link
Member

puerco commented May 7, 2021

/test pull-kubernetes-e2e-kind-ipv6

@justaugustus
Copy link
Member Author

/test pull-kubernetes-e2e-gce-ubuntu-containerd

@puerco
Copy link
Member

puerco commented May 7, 2021

/lgtm

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 7, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 7, 2021
@justaugustus
Copy link
Member Author

@kubernetes/release-managers -- Needs cherry pick approval.

/hold cancel
#101809 (comment) has merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2021
@puerco
Copy link
Member

puerco commented May 7, 2021

Inception

@justaugustus
Copy link
Member Author

Hehe, thanks Adolfo!

@k8s-ci-robot k8s-ci-robot merged commit 454ab21 into kubernetes:release-1.21 May 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone May 7, 2021
@justaugustus justaugustus mentioned this pull request May 8, 2021
Closed
27 tasks
@github-actions github-actions bot mentioned this pull request May 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder Awaiting requested review from BenTheElder

@dashpole dashpole Awaiting requested review from dashpole

Assignees

@dims dims

@liggitt liggitt

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/provider/gcp Issues or PRs related to gcp provider area/release-eng Issues or PRs related to the Release Engineering subproject area/security area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
5 participants
@justaugustus @k8s-ci-robot @liggitt @dims @puerco