Remove deprecated alpha Service topologyKeys field #102412

andrewsykim · 2021-05-28T16:38:10Z

What type of PR is this?

/kind cleanup
/kind api-change
/kind deprecation

What this PR does / why we need it:

ServiceTopology has been deprecated for 2 releases now in alpha. Future direction is in favor of topology-aware hints or internal traffic policy. With both of these features now in alpha, it is safe to remove the topologyKeys API and the kube-proxy implementation of it.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

[ACTION REQUIRED] Remove support for the Service topologyKeys field (alpha) and the kube-proxy implementation of it.  This field was deprecated several cycles ago.  This functionality is replaced by the combination of automatic topology hints per-endpoint (alpha) and the Service internalTrafficPolicy field (alpha).

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

aojea · 2021-05-28T17:05:06Z

Is not common to leave a tombstone for the deprecated fields ?

staging/src/k8s.io/api/core/v1/types.go

smarterclayton · 2021-06-01T14:11:08Z

staging/src/k8s.io/api/core/v1/types_test.go

looks good, thanks for adding

fedebongio · 2021-06-01T20:06:29Z

/remove-sig api-machinery

fejta-bot · 2021-06-04T04:09:44Z

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

andrewsykim · 2021-06-04T15:50:30Z

/retest

thockin · 2021-06-04T15:59:48Z

I edited your release note a bit - PTAL.

andrewsykim · 2021-06-04T16:02:28Z

Thanks, looks better now. I also added a [ACTION REQUIRED] at the start

thockin

Thanks!

/lgtm
/approve

k8s-ci-robot · 2021-06-04T16:04:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~api/OWNERS~~ [thockin]
~~cmd/kube-proxy/OWNERS~~ [andrewsykim,thockin]
~~pkg/apis/OWNERS~~ [thockin]
~~pkg/features/OWNERS~~ [andrewsykim,thockin]
~~pkg/proxy/OWNERS~~ [andrewsykim,thockin]
~~pkg/registry/OWNERS~~ [thockin]
~~staging/src/k8s.io/api/OWNERS~~ [thockin]
~~staging/src/k8s.io/client-go/OWNERS~~ [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This PR updates the feature gate status based on upstream implementation. The chanegs are listed below with links to upstream PRs merged: - BalanceAttacedNodeVolumes kubernetes/kubernetes#102443 - CSIMigrationvSphereComplete kubernetes/kubernetes#101272 - CSIServiceAccountToken kubernetes/kubernetes#103001 - DaemonSetUpdateSurge kubernetes/kubernetes#101742 - DisableCloudProviders kubernetes/kubernetes#100136 - IndexedJob kubernetes/kubernetes#101292 - LegacyNodeRoleBehavior kubernetes/kubernetes#100776 - NamespaceDefaultLabelName kubernetes/kubernetes#101342 - NetworkPolicyEndPort kubernetes/kubernetes#102834 - NodeDisruptionExclusion kubernetes/kubernetes#100776 - PodAffinityNamespaceSelector kubernetes/kubernetes#101496 - PodDeletionCost kubernetes/kubernetes#101080 - PreferNominatedNode kubernetes/kubernetes#102201 - ServiceLoadBalancerClass kubernetes/kubernetes#103129 - ServiceNodeExclusion kubernetes/kubernetes#100776 - ServiceTopology kubernetes/kubernetes#102412 - SizeMemoryBackedVoluems kubernetes/kubernetes#101048 - StatefulSetMinReadySeconds kubernetes/kubernetes#100842 - SuspendJob kubernetes/kubernetes#102022 - WindowsHostProcessContainers kubernetes/kubernetes#99576

k8s-ci-robot requested review from aojea and bowei May 28, 2021 16:39

andrewsykim commented May 28, 2021

View reviewed changes

staging/src/k8s.io/api/core/v1/types.go Outdated Show resolved Hide resolved

andrewsykim force-pushed the kill-service-topology branch 2 times, most recently from a1024b9 to 01e425d Compare May 28, 2021 18:10

smarterclayton reviewed Jun 1, 2021

View reviewed changes

staging/src/k8s.io/api/core/v1/types_test.go Outdated

Copy link

Contributor

smarterclayton Jun 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for adding

k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 1, 2021

andrewsykim force-pushed the kill-service-topology branch from 01e425d to 6f03051 Compare June 4, 2021 01:09

k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 4, 2021

andrewsykim force-pushed the kill-service-topology branch from 6f03051 to aee4ddc Compare June 4, 2021 01:11

andrewsykim changed the title ~~[WIP] Remove support for ServiceTopology~~ Remove support for ServiceTopology Jun 4, 2021

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2021

k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 4, 2021

thockin reviewed Jun 4, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2021

thockin changed the title ~~Remove support for ServiceTopology~~ Remove support for deprecated alpha Service topologyKeys field Jun 4, 2021

thockin changed the title ~~Remove support for deprecated alpha Service topologyKeys field~~ Remove deprecated alpha Service topologyKeys field Jun 4, 2021

k8s-ci-robot merged commit 7ed2ed1 into kubernetes:master Jun 4, 2021

k8s-ci-robot added this to the v1.22 milestone Jun 4, 2021

tengqm mentioned this pull request Jun 27, 2021

Update feature gates for 1.22 kubernetes/website#28644

Merged

kevinpollet mentioned this pull request Dec 30, 2021

Update k8s.io/client-go dependency to v0.22.5 traefik/mesh#808

Merged

jfeddern mentioned this pull request Apr 14, 2022

Remove service topologyKeys due to removal in K8S 1.22 instana/helm-charts#11

Closed

3 tasks

ialidzhikov mentioned this pull request Nov 1, 2022

[GEP-20] Reduce Cross-zonal Traffic via Topology Aware Hints gardener/gardener#6718

Closed

46 tasks

This was referenced Nov 21, 2022

Remove seedTemplate field from ManagedSeed API gardener/gardener#6972

Merged

Add docs about field removal gardener/gardener#7049

Merged

dipesh-rawat mentioned this pull request Apr 10, 2023

Remove deprecated doc on Topology-aware traffic routing with topology keys kubernetes/website#40605

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove deprecated alpha Service topologyKeys field #102412

Remove deprecated alpha Service topologyKeys field #102412

Uh oh!

andrewsykim commented May 28, 2021 •

edited by thockin

Loading

Uh oh!

aojea commented May 28, 2021

Uh oh!

Uh oh!

smarterclayton Jun 1, 2021

Uh oh!

fedebongio commented Jun 1, 2021

Uh oh!

fejta-bot commented Jun 4, 2021

Uh oh!

andrewsykim commented Jun 4, 2021

Uh oh!

thockin commented Jun 4, 2021

Uh oh!

andrewsykim commented Jun 4, 2021

Uh oh!

thockin left a comment

Uh oh!

k8s-ci-robot commented Jun 4, 2021

Uh oh!

Uh oh!

Remove deprecated alpha Service topologyKeys field #102412

Remove deprecated alpha Service topologyKeys field #102412

Uh oh!

Conversation

andrewsykim commented May 28, 2021 • edited by thockin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

aojea commented May 28, 2021

Uh oh!

Uh oh!

smarterclayton Jun 1, 2021

Choose a reason for hiding this comment

Uh oh!

fedebongio commented Jun 1, 2021

Uh oh!

fejta-bot commented Jun 4, 2021

Uh oh!

andrewsykim commented Jun 4, 2021

Uh oh!

thockin commented Jun 4, 2021

Uh oh!

andrewsykim commented Jun 4, 2021

Uh oh!

thockin left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Jun 4, 2021

Uh oh!

Uh oh!

andrewsykim commented May 28, 2021 •

edited by thockin

Loading