Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Automated cherry pick of #102176: Fix VolumeAttachment garbage collection for migrated PVs #102458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2021
Merged

Automated cherry pick of #102176: Fix VolumeAttachment garbage collection for migrated PVs #102458

merged 1 commit into from
Jun 8, 2021

Conversation

timebertt
Copy link
Contributor

Cherry pick of #102176 on release-1.19.

#102176: Fix VolumeAttachment garbage collection for migrated PVs

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone May 31, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 31, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @timebertt. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 31, 2021
@timebertt
Copy link
Contributor Author

/kind bug
/sig storage
/cc @gnufied @Jiawei0227
/priority important-soon

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. sig/storage Categorizes an issue or PR as relevant to SIG Storage. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels May 31, 2021
@k8s-ci-robot k8s-ci-robot requested a review from rootfs May 31, 2021 11:13
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label May 31, 2021
@gnufied
Copy link
Member

gnufied commented Jun 1, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 1, 2021
@gnufied
Copy link
Member

gnufied commented Jun 1, 2021

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 1, 2021
@timebertt timebertt force-pushed the automated-cherry-pick-of-#102176-origin-release-1.19 branch from 7509638 to e58f614 Compare June 2, 2021 07:24
@timebertt
Copy link
Contributor Author

/retest

@timebertt
Copy link
Contributor Author

Checks are all green now.
/assign @gnufied
for approval :)

@gnufied
Copy link
Member

gnufied commented Jun 2, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, timebertt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2021
@timebertt
Copy link
Contributor Author

/cc @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested a review from a team June 2, 2021 14:20
@liggitt
Copy link
Member

liggitt commented Jun 5, 2021

Is this fixing a regression or backporting a fix for a pre-existing bug? What are the risks of this change introducing a new regression to existing clusters?

@gnufied
Copy link
Member

gnufied commented Jun 5, 2021

This is fix for a pre-existing bug. The bug should only affect users who disable the intree plugins (via CSIMigrateXXXComplete feature gates). It is pretty serious bug if you are using that feature gate, but the feature gate is disabled by default - so not as important I think.

I think - it has pretty low chance of introducing a regression in existing clusters since code is written in a way that will only affect migrated CSI drivers.

This was referenced Jun 7, 2021
Merged
Merged
@puerco
Copy link
Member

puerco commented Jun 8, 2021

/lgtm
Thanks @timebertt

@puerco puerco added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jun 8, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Jun 8, 2021
@k8s-ci-robot k8s-ci-robot merged commit 57534d0 into kubernetes:release-1.19 Jun 8, 2021
@timebertt timebertt deleted the automated-cherry-pick-of-#102176-origin-release-1.19 branch June 8, 2021 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnufied gnufied Awaiting requested review from gnufied

@Jiawei0227 Jiawei0227 Awaiting requested review from Jiawei0227

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@gnufied gnufied

@puerco puerco

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.
5 participants
@timebertt @k8s-ci-robot @gnufied @liggitt @puerco