Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(kubeadm): remove the flag --port from KCM manifest #104157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2021
Merged

refactor(kubeadm): remove the flag --port from KCM manifest #104157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cmd/kubeadm/app/phases/controlplane/manifests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,6 @@ func getControllerManagerCommand(cfg *kubeadmapi.ClusterConfiguration) []string
caFile := filepath.Join(cfg.CertificatesDir, kubeadmconstants.CACertName)

defaultArguments := map[string]string{
"port": "0",
"bind-address": "127.0.0.1",
"leader-elect": "true",
"kubeconfig": kubeconfigFile,
Expand Down
11 changes: 0 additions & 11 deletions cmd/kubeadm/app/phases/controlplane/manifests_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,6 @@ func TestGetControllerManagerCommand(t *testing.T) {
},
expected: []string{
"kube-controller-manager",
"--port=0",
"--bind-address=127.0.0.1",
"--leader-elect=true",
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
Expand All @@ -576,7 +575,6 @@ func TestGetControllerManagerCommand(t *testing.T) {
},
expected: []string{
"kube-controller-manager",
"--port=0",
"--bind-address=127.0.0.1",
"--leader-elect=true",
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
Expand All @@ -601,7 +599,6 @@ func TestGetControllerManagerCommand(t *testing.T) {
},
expected: []string{
"kube-controller-manager",
"--port=0",
"--bind-address=127.0.0.1",
"--leader-elect=true",
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
Expand Down Expand Up @@ -633,7 +630,6 @@ func TestGetControllerManagerCommand(t *testing.T) {
},
expected: []string{
"kube-controller-manager",
"--port=0",
"--bind-address=127.0.0.1",
"--leader-elect=true",
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
Expand Down Expand Up @@ -665,7 +661,6 @@ func TestGetControllerManagerCommand(t *testing.T) {
},
expected: []string{
"kube-controller-manager",
"--port=0",
"--bind-address=127.0.0.1",
"--leader-elect=true",
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
Expand Down Expand Up @@ -698,7 +693,6 @@ func TestGetControllerManagerCommand(t *testing.T) {
},
expected: []string{
"kube-controller-manager",
"--port=0",
"--bind-address=127.0.0.1",
"--leader-elect=true",
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
Expand Down Expand Up @@ -733,7 +727,6 @@ func TestGetControllerManagerCommand(t *testing.T) {
},
expected: []string{
"kube-controller-manager",
"--port=0",
"--bind-address=127.0.0.1",
"--leader-elect=true",
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
Expand Down Expand Up @@ -766,7 +759,6 @@ func TestGetControllerManagerCommand(t *testing.T) {
},
expected: []string{
"kube-controller-manager",
"--port=0",
"--bind-address=127.0.0.1",
"--leader-elect=true",
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
Expand Down Expand Up @@ -801,7 +793,6 @@ func TestGetControllerManagerCommand(t *testing.T) {
},
expected: []string{
"kube-controller-manager",
"--port=0",
"--bind-address=127.0.0.1",
"--leader-elect=true",
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
Expand Down Expand Up @@ -855,7 +846,6 @@ func TestGetControllerManagerCommandExternalCA(t *testing.T) {
expectedArgFunc: func(tmpdir string) []string {
return []string{
"kube-controller-manager",
"--port=0",
"--bind-address=127.0.0.1",
"--leader-elect=true",
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
Expand Down Expand Up @@ -885,7 +875,6 @@ func TestGetControllerManagerCommandExternalCA(t *testing.T) {
expectedArgFunc: func(tmpdir string) []string {
return []string{
"kube-controller-manager",
"--port=0",
"--bind-address=127.0.0.1",
"--leader-elect=true",
"--kubeconfig=" + kubeadmconstants.KubernetesDir + "/controller-manager.conf",
Expand Down