kubectl resource builder: don't check extension for single files #10866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`kubectl create -f filename` doesn't need to check the extension of filename. This fixes that behavior.
|
GCE e2e build/test passed for commit 8d4167e. |
|
@jlowdermilk, if this PR is for v1.0, please ping @bgrant0607 directly to confirm. Thanks! |
|
This is post-1.0. No rush |
|
LGTM. Thanks! Can you rebase then I'll tag this? |
|
GCE e2e build/test passed for commit 8d4167e. |
mikedanese
added a commit
that referenced
this pull request
Jul 24, 2015
kubectl resource builder: don't check extension for single files
k8s-github-robot
referenced
this pull request
Sep 5, 2015
…10866-upstream-release-1.0 Auto commit by PR queue bot
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubectl create -f filenamedoesn't need to check the extensionof filename. This fixes that behavior. Fixes #10853
cc @andronat, @mikedanese