-
Notifications
You must be signed in to change notification settings - Fork 41.5k
add spec.host as a synonym for spec.nodeName in v1 #11084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM |
ah LGTM, thanks! |
LGTM |
cc @rjnagal for merge |
Thanks @brendandburns! |
Thank you @brendanburns ! So the mistake is that I failed to catch #10076 before sending #9269. |
…84-on-upstream-release-0.21 Automated cherry pick of #11084
waiting to merge: shippable is slow |
I'm prepping the release branch anyways - we've done some amount of internal validation. If there's a unit test failure or something else, we can push a minor change, but integration tests seem to be fine. |
(To be clear, this passes on my own testing.) |
GCE e2e build/test passed for commit 2f47b3e. |
shippable failure: ./hack/verify-gofmt.sh |
Yeah. It's a shame |
(cherry picked from commit 63c73a5)
GCE e2e build/test passed for commit 6ea0c2b. |
Merging so I can get #11097 in (so master can look like v0.21.2 sometime tonight). |
add spec.host as a synonym for spec.nodeName in v1
(Shippable just went green, finally.) |
This fixes a breaking change between different v1 api clients (0.19.3 to head)