Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

brendandburns
Copy link
Contributor

This fixes a breaking change between different v1 api clients (0.19.3 to head)

@bgrant0607
Copy link
Member

LGTM

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2015
@bgrant0607
Copy link
Member

cc @nikhiljindal @caesarxuchao

@bgrant0607
Copy link
Member

Addresses incompatible change made in #10076, which was made after v1 was enabled by default in #9269

@nikhiljindal
Copy link
Contributor

ah LGTM, thanks!
Sorry for not catching this earlier.

@lavalamp
Copy link
Contributor

LGTM

@bgrant0607
Copy link
Member

cc @rjnagal for merge

@roberthbailey
Copy link
Contributor

Thanks @brendandburns!

@caesarxuchao
Copy link
Contributor

Thank you @brendanburns !

So the mistake is that I failed to catch #10076 before sending #9269.

zmerlynn added a commit that referenced this pull request Jul 10, 2015
…84-on-upstream-release-0.21

Automated cherry pick of #11084
@rjnagal
Copy link
Contributor

rjnagal commented Jul 10, 2015

waiting to merge: shippable is slow

@zmerlynn zmerlynn mentioned this pull request Jul 10, 2015
@zmerlynn
Copy link
Member

I'm prepping the release branch anyways - we've done some amount of internal validation. If there's a unit test failure or something else, we can push a minor change, but integration tests seem to be fine.

@zmerlynn
Copy link
Member

(To be clear, this passes on my own testing.)

@k8s-bot
Copy link

k8s-bot commented Jul 10, 2015

GCE e2e build/test passed for commit 2f47b3e.

@rjnagal
Copy link
Contributor

rjnagal commented Jul 10, 2015

shippable failure:

./hack/verify-gofmt.sh
!!! 'gofmt -s' needs to be run on the following files:
./pkg/api/v1/conversion.go

@zmerlynn
Copy link
Member

Yeah. It's a shame make release doesn't even catch that. Sigh.

zmerlynn added a commit to zmerlynn/kubernetes that referenced this pull request Jul 11, 2015
zmerlynn added a commit that referenced this pull request Jul 11, 2015
(cherry picked from commit 63c73a5)
@k8s-bot
Copy link

k8s-bot commented Jul 11, 2015

GCE e2e build/test passed for commit 6ea0c2b.

@zmerlynn
Copy link
Member

Merging so I can get #11097 in (so master can look like v0.21.2 sometime tonight).

zmerlynn added a commit that referenced this pull request Jul 11, 2015
add spec.host as a synonym for spec.nodeName in v1
@zmerlynn zmerlynn merged commit 196ed7d into kubernetes:master Jul 11, 2015
@zmerlynn
Copy link
Member

(Shippable just went green, finally.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants