Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Aggregated discovery types #111978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2022
Merged

Aggregated discovery types #111978

merged 1 commit into from
Oct 19, 2022

Conversation

Jefftree
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add types for aggregated discovery

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

KEP: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/3352-aggregated-discovery

/assign @deads2k

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 23, 2022
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.25 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.25.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Tue Aug 23 19:46:32 UTC 2022.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation labels Aug 23, 2022
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 23, 2022
@leilajal
Copy link
Contributor

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 23, 2022
@Jefftree
Copy link
Member Author

/cc @alexzielenski @apelisse @seans3

@Jefftree Jefftree force-pushed the aggregated-discovery-types branch 2 times, most recently from 3afbff2 to 6881580 Compare August 23, 2022 20:37
@k8s-triage-robot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@Jefftree Jefftree force-pushed the aggregated-discovery-types branch 2 times, most recently from 29b92c9 to 83344d8 Compare August 24, 2022 18:48
deads2k
deads2k reviewed Aug 24, 2022
View reviewed changes
deads2k
deads2k reviewed Aug 24, 2022
View reviewed changes
deads2k
deads2k reviewed Aug 24, 2022
View reviewed changes
@Jefftree Jefftree force-pushed the aggregated-discovery-types branch from aa76cd4 to b5c51a3 Compare October 18, 2022 17:40
smarterclayton
smarterclayton reviewed Oct 18, 2022
View reviewed changes
smarterclayton
smarterclayton reviewed Oct 18, 2022
View reviewed changes
@Jefftree Jefftree force-pushed the aggregated-discovery-types branch from b5c51a3 to 0065f95 Compare October 18, 2022 17:53
smarterclayton
smarterclayton reviewed Oct 18, 2022
View reviewed changes
@Jefftree
Copy link
Member Author

There was a drift between the internal/external version godocs earlier which may have caused some comments to not be addressed in one version. That has been fixed.

@Jefftree Jefftree force-pushed the aggregated-discovery-types branch 2 times, most recently from db62188 to 73b62fd Compare October 18, 2022 22:07
@Jefftree
Copy link
Member Author

/test pull-kubernetes-e2e-kind-ipv6

   Oct 18 22:35:13.426: INFO: Unexpected error: 
        <*errors.errorString | 0xc000293d00>: {
            s: "timed out waiting for the condition",
        }
    Oct 18 22:35:13.426: FAIL: timed out waiting for the condition

@Jefftree Jefftree force-pushed the aggregated-discovery-types branch from 73b62fd to e656876 Compare October 19, 2022 02:11
smarterclayton
smarterclayton reviewed Oct 19, 2022
View reviewed changes
smarterclayton
smarterclayton reviewed Oct 19, 2022
View reviewed changes
smarterclayton
smarterclayton reviewed Oct 19, 2022
View reviewed changes
smarterclayton
smarterclayton reviewed Oct 19, 2022
View reviewed changes
@smarterclayton
Copy link
Contributor

I think that's the last set of comments, everything else looks good.

@Jefftree Jefftree force-pushed the aggregated-discovery-types branch 2 times, most recently from ca9959c to 737d370 Compare October 19, 2022 17:24
@Jefftree
Copy link
Member Author

@smarterclayton @liggitt Rebased, squashed and all comments should be addressed.

@Jefftree Jefftree force-pushed the aggregated-discovery-types branch from 737d370 to 2e01fbb Compare October 19, 2022 17:27
@smarterclayton
Copy link
Contributor

/lgtm
/approve

Thanks for your patience!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2022
@liggitt
Copy link
Member

liggitt commented Oct 19, 2022

approve for new package in modules.txt

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2022
@k8s-ci-robot k8s-ci-robot merged commit a2827c4 into kubernetes:master Oct 19, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Oct 19, 2022
@Jefftree Jefftree mentioned this pull request Oct 25, 2022
Merged
@Jefftree Jefftree deleted the aggregated-discovery-types branch December 2, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@smarterclayton smarterclayton smarterclayton left review comments

@apelisse apelisse apelisse left review comments

@deads2k deads2k deads2k requested changes

+4 more reviewers

@alexzielenski alexzielenski alexzielenski left review comments

@lavalamp lavalamp lavalamp left review comments

@stevekuznetsov stevekuznetsov stevekuznetsov left review comments

@seans3 seans3 seans3 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@smarterclayton smarterclayton

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.26
Development

Successfully merging this pull request may close these issues.