Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] Aggregated Discovery: crd discovery information #112130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 12 commits into from
Closed

[WIP] Aggregated Discovery: crd discovery information #112130

wants to merge 12 commits into from

Conversation

alexzielenski
Copy link
Member

@alexzielenski alexzielenski commented Aug 30, 2022 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR builds upon #112113 by adding ResourceManager bindings to apiextensions-apiserver's DiscoveryController. This enables discovery information for CRDs to be populated within the discovery document for the apiextensions-apiserver.

/sig api-machinery
/cc @Jefftree @apelisse @seans3
/assign @Jefftree

depends on:

#111978
#112112
#112113

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-api-machinery/3352-aggregated-discovery

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 30, 2022
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Aug 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexzielenski
Once this PR has been reviewed and has the lgtm label, please assign lavalamp for approval by writing /assign @lavalamp in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/apiserver area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Aug 30, 2022
@leilajal
Copy link
Contributor

leilajal commented Sep 1, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 1, 2022
@alexzielenski alexzielenski force-pushed the aggregated-discovery-crds branch from 260ed5d to ff8e3e1 Compare September 1, 2022 20:44
@alexzielenski alexzielenski force-pushed the aggregated-discovery-crds branch from ff8e3e1 to 7b44017 Compare September 2, 2022 22:51
@alexzielenski alexzielenski force-pushed the aggregated-discovery-crds branch from 7b44017 to 0c6dc38 Compare September 2, 2022 22:56
@alexzielenski alexzielenski force-pushed the aggregated-discovery-crds branch from 0c6dc38 to ce52f31 Compare September 2, 2022 22:56
@k8s-ci-robot
Copy link
Contributor

@alexzielenski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubernetes-verify ce52f31 link true /test pull-kubernetes-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ruheenaansari34 ruheenaansari34 mentioned this pull request Nov 2, 2022
Closed
11 tasks
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 6, 2022
@k8s-ci-robot
Copy link
Contributor

@alexzielenski: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Jefftree
Copy link
Member

/close

Superseded by #113171

@k8s-ci-robot
Copy link
Contributor

@Jefftree: Closed this PR.

In response to this:

/close

Superseded by #113171

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alexzielenski alexzielenski deleted the aggregated-discovery-crds branch November 16, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse Awaiting requested review from apelisse

@Jefftree Jefftree Awaiting requested review from Jefftree

@seans3 seans3 Awaiting requested review from seans3

Assignees

@Jefftree Jefftree

Labels
area/apiserver area/code-generation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexzielenski @k8s-ci-robot @leilajal @Jefftree