Required for AWS support. Justin, I presume this would need to be cherry-picked into release-1.0?

GCE e2e build/test passed for commit 355e922.

• Build Log
• Test Artifacts
• Internal Jenkins Results

@justinsb cherry pick for 1.0 or not?

On Tue, Jul 14, 2015 at 1:04 PM, Eric Tune [email protected] wrote:

Merged #11241
#11241.

—
Reply to this email directly or view it on GitHub
#11241 (comment)
.

It's only for KUBE_ENABLE_MINION_PUBLIC_IP=false, which is not the common configuration, but we do document it. The patch is low risk (adds a function to a bash file), so I think we should probably merge it, but I'm not sure exactly how problematic it is to cherry-pick things to 1.0 at this point in the cycle. If we have a 1.0.1 backlog this might be a candidate for that.

Cherry picking IS the 1.0.1 queue-up :)

Can you try running ./hack/cherry_pick_pull.sh (so someone outside of us
can try it :) ?

On Tue, Jul 14, 2015 at 2:03 PM, Justin Santa Barbara <
[email protected]> wrote:

It's only for KUBE_ENABLE_MINION_PUBLIC_IP=false, which is not the common
configuration, but we do document it. The patch is low risk (adds a
function to a bash file), so I think we should probably merge it, but I'm
not sure exactly how problematic it is to cherry-pick things to 1.0 at this
point in the cycle. If we have a 1.0.1 backlog this might be a candidate
for that.

—
Reply to this email directly or view it on GitHub
#11241 (comment)
.