Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add namespace to swagger nicknames to prevent duplicate nicknames #11258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2015
Merged

Add namespace to swagger nicknames to prevent duplicate nicknames #11258

merged 1 commit into from
Jul 15, 2015

Conversation

nikhiljindal
Copy link
Contributor

Fixes #11229

cc @bgrant0607

Post 1.0

@k8s-bot
Copy link

k8s-bot commented Jul 14, 2015

GCE e2e build/test passed for commit dda71bd.

@erictune erictune added this to the v1.0-post milestone Jul 14, 2015
@bgrant0607
Copy link
Member

We might need this for generated docs. @caesarxuchao

LGTM. Please create a cherrypick PR after this is merged.

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 15, 2015
@bgrant0607 bgrant0607 modified the milestones: v1.0, v1.0-post Jul 15, 2015
@bgrant0607
Copy link
Member

Shippable failure was due to doc move. Restarting shippable. If that doesn't work you might need to rebase.

@bgrant0607 bgrant0607 closed this Jul 15, 2015
@bgrant0607 bgrant0607 reopened this Jul 15, 2015
@bgrant0607 bgrant0607 assigned lavalamp and unassigned bgrant0607 Jul 15, 2015
@bgrant0607
Copy link
Member

Reassigned to @lavalamp for another LGTM

@lavalamp
Copy link
Contributor

LGTM

@lavalamp
Copy link
Contributor

Just to verify: were clients using this nickname field? I'm assuming not, because otherwise this change would not be safe?

@erictune erictune modified the milestones: v1.0-post, v1.0 Jul 15, 2015
erictune added a commit that referenced this pull request Jul 15, 2015
@erictune
Merge pull request #11258 from nikhiljindal/dupNickname
d7a0bb4 
Add namespace to swagger nicknames to prevent duplicate nicknames
@erictune erictune merged commit d7a0bb4 into kubernetes:master Jul 15, 2015
@nikhiljindal
Copy link
Contributor Author

@lavalamp Users will have to recreate their client from updated swagger spec, to pick up this change.

Earlier, there was no way for them to send a namespaced request (Both namespaced and unnamespaced had the same nickname, and namespaced one was overwritten by the unnamespaced one).
After this change, they will be still be able to send the unnamespaced request using the old nickname. We now have a new nickname for namespaced requests.

So hopefully, this doesnt break anything :)

@nikhiljindal nikhiljindal mentioned this pull request Jul 16, 2015
Merged
@nikhiljindal
Copy link
Contributor Author

Cherrypick request: #11347

zmerlynn added a commit that referenced this pull request Jul 16, 2015
@zmerlynn
Merge pull request #11347 from nikhiljindal/automated-cherry-pick-of-…
9bff647 
…#11258-upstream-release-1.0

Automated cherry pick of #11258
@zmerlynn zmerlynn mentioned this pull request Jul 17, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
v1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nikhiljindal @k8s-bot @bgrant0607 @lavalamp @googlebot @erictune