Thanks to visit codestin.com
Credit goes to github.com

Skip to content

solve race on NewHTTPProxyHandler #115230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 20, 2023
Merged

solve race on NewHTTPProxyHandler #115230

merged 1 commit into from
Jan 20, 2023

Conversation

aojea
Copy link
Member

@aojea aojea commented Jan 20, 2023 •
edited
Loading

/kind flake

NONE

Fixes: #115232
Fixes the flake, since it seems it is calling t.Logf after the test ends
#113637 (comment)

$ go test -timeout 30s -run ^TestRoundTripAndNewConnection$ k8s.io/apimachinery/pkg/util/httpstream/spdy -race -c
$ stress ./spdy.test -test.run TestRoundTripAndNewConnection
5s: 353 runs so far, 0 failures
10s: 712 runs so far, 0 failures
15s: 1074 runs so far, 0 failures
20s: 1425 runs so far, 0 failures
25s: 1772 runs so far, 0 failures
30s: 2108 runs so far, 0 failures
35s: 2426 runs so far, 0 failures
40s: 2736 runs so far, 0 failures
45s: 3034 runs so far, 0 failures
50s: 3321 runs so far, 0 failures
55s: 3595 runs so far, 0 failures
1m0s: 3869 runs so far, 0 failures
1m5s: 4208 runs so far, 0 failures
1m10s: 4592 runs so far, 0 failures
1m15s: 4961 runs so far, 0 failures
1m20s: 5319 runs so far, 0 failures
1m25s: 5667 runs so far, 0 failures

@aojea
solve race on NewHTTPProxyHandler
80606c8 
Change-Id: I993ac447c31afa52cc2e53cd9a61069fb6d91253
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 20, 2023
@aojea
Copy link
Member Author

aojea commented Jan 20, 2023

/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Jan 20, 2023
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 20, 2023
@liggitt liggitt added this to the next-candidate milestone Jan 20, 2023
@liggitt
Copy link
Member

liggitt commented Jan 20, 2023

/lgtm
/approve
/triage accepted
/priority important-soon

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jan 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7ba30694471e473d131394de159a6265ac57df1d

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aojea, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@aojea
Copy link
Member Author

aojea commented Jan 20, 2023

/retest
k8s.io/kubernetes/vendor/k8s.io/kube-aggregator/pkg/apiserver: TestRemoveAPIService expand_less

I saw this failing lately

handler_discovery_test.go:203: expected to find no groups after service deletion (got 2 groups)

@liggitt
Copy link
Member

liggitt commented Jan 20, 2023

I saw this failing lately

handler_discovery_test.go:203: expected to find no groups after service deletion (got 2 groups)

looks like that's been around for a while... https://storage.googleapis.com/k8s-triage/index.html?date=2022-11-24&pr=1&text=expected%20to%20find%20no%20groups%20after%20service%20deletion

@liggitt
Copy link
Member

liggitt commented Jan 20, 2023

I saw this failing lately

handler_discovery_test.go:203: expected to find no groups after service deletion (got 2 groups)

looks like that's been around for a while... https://storage.googleapis.com/k8s-triage/index.html?date=2022-11-24&pr=1&text=expected%20to%20find%20no%20groups%20after%20service%20deletion

cc @alexzielenski - added in #113171

@alexzielenski
Copy link
Member

Will take a look

@aojea
Copy link
Member Author

aojea commented Jan 20, 2023

Kubernetes e2e suite: [It] [sig-node] Pods Extended Pod Container lifecycle should not create extra sandbox if all containers are done expand_more

/retest

@aojea aojea mentioned this pull request Jan 20, 2023
Closed
@k8s-ci-robot k8s-ci-robot merged commit 9787f46 into kubernetes:master Jan 20, 2023
@k8s-ci-robot k8s-ci-robot modified the milestones: next-candidate, v1.27 Jan 20, 2023
@alexzielenski alexzielenski mentioned this pull request Jan 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@logicalhan logicalhan Awaiting requested review from logicalhan

@thockin thockin Awaiting requested review from thockin

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

[Flaky test] Data Race in ci-kubernetes-unit (TestRoundTripSocks5AndNewConnection)
4 participants
@aojea @liggitt @k8s-ci-robot @alexzielenski