Don't reuse credentials on cluster create #13068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #13060 |
|
GCE e2e build/test failed for commit cd69a4e5f4fbb2670a19e074f8039a9caba081cb. |
|
GCE e2e build/test passed for commit 4382168. |
|
LGTM, but what will this do to people who have more than one cluster of a particular provider (e.g. dev and e2e)? |
|
Multiple clusters will get different credentials, even if they are the same provider. Arguably, that is the correct approach anyway. Note that this doesn't mean that the older cluster credentials get overwritten; if you have e.g. a 'dev' and 'e2e' gce cluster, you will have 2 kubeconfig entries for them, and can switch between them by using |
|
lgtm |
nikhiljindal
added a commit
that referenced
this pull request
Aug 24, 2015
Don't reuse credentials on cluster create
mikedanese
added a commit
that referenced
this pull request
Sep 16, 2015
…13068-upstream-release-1.0 Automated cherry pick of #13068
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@justinsb, @thockin, @brendandburns