Thanks to visit codestin.com
Credit goes to github.com

Skip to content

track gopkg.in/yaml.v3 as an unwanted depdendency #131454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

track gopkg.in/yaml.v3 as an unwanted depdendency #131454

merged 1 commit into from
Apr 25, 2025

Conversation

BenTheElder
Copy link
Member

@BenTheElder BenTheElder commented Apr 24, 2025 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The repo for gopkg.in/yaml.v3 (which also has yaml.v2) was archived.

x-ref #120276, https://github.com/go-yaml/yaml

We have a fork of it already in sigs.k8s.io/yaml/goyaml.v3

Start tracking as an unwanted dependency (we were already tracking gopkg.in/yaml.v2)

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig architecture
/area code-organization

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/code-organization Issues or PRs related to kubernetes code organization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 24, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 24, 2025
@k8s-ci-robot k8s-ci-robot requested review from sttts and thockin April 24, 2025 21:49
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2025
BenTheElder
BenTheElder commented Apr 24, 2025
View reviewed changes
hack/unwanted-dependencies.json
@@ -77,9 +77,10 @@
"google.golang.org/api": "cloud dependency",
"google.golang.org/appengine": "cloud dependency",
"google.golang.org/genproto": "refer to #113366",
"gopkg.in/square/go-jose.v2":"obsolete, use gopkg.in/go-jose/go-jose.v2",
"gopkg.in/square/go-jose.v2": "obsolete, use gopkg.in/go-jose/go-jose.v2",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was auto formatted by vscode but it's also the only one with the missing space so I didn't try to revert it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@BenTheElder
track gopkg.in/yaml.v3 as an unwanted depdendency
0879497 
this repo (which also has yaml.v2) was archived

we have a fork of it already in sigs.k8s.io/yaml/goyaml.v3
@dims
Copy link
Member

dims commented Apr 24, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1bcb373dd5ec425190f62632882e56d24d5ead34

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dims
Copy link
Member

dims commented Apr 24, 2025 

❯ rg 'gopkg.in/yaml.v3"' | grep -v vendor/gopkg.in/yaml.v3
vendor/github.com/go-openapi/swag/yaml.go:      yaml "gopkg.in/yaml.v3"
vendor/github.com/onsi/gomega/matchers/match_yaml_matcher.go:   "gopkg.in/yaml.v3"
vendor/github.com/spf13/cobra/doc/yaml_docs.go: "gopkg.in/yaml.v3"
vendor/github.com/stretchr/testify/assert/yaml/yaml_default.go:import goyaml "gopkg.in/yaml.v3"
vendor/sigs.k8s.io/yaml/goyaml.v3/README.md:        "gopkg.in/yaml.v3"
vendor/github.com/google/gnostic-models/openapiv2/OpenAPIv2.go: "gopkg.in/yaml.v3"
vendor/github.com/google/gnostic-models/openapiv2/document.go:  "gopkg.in/yaml.v3"
vendor/github.com/google/gnostic-models/compiler/helpers.go:    "gopkg.in/yaml.v3"
vendor/github.com/google/gnostic-models/compiler/reader.go:     yaml "gopkg.in/yaml.v3"
vendor/github.com/google/gnostic-models/compiler/extensions.go: yaml "gopkg.in/yaml.v3"
vendor/github.com/google/gnostic-models/compiler/context.go:    yaml "gopkg.in/yaml.v3"
vendor/github.com/google/gnostic-models/openapiv3/OpenAPIv3.go: "gopkg.in/yaml.v3"
vendor/github.com/google/gnostic-models/openapiv3/document.go:  "gopkg.in/yaml.v3"
vendor/github.com/google/gnostic-models/jsonschema/reader.go:   "gopkg.in/yaml.v3"
vendor/github.com/google/gnostic-models/jsonschema/writer.go:   "gopkg.in/yaml.v3"
vendor/github.com/google/gnostic-models/jsonschema/models.go:import "gopkg.in/yaml.v3"
vendor/k8s.io/kube-openapi/pkg/util/proto/document_v3.go:       "gopkg.in/yaml.v3"

This was referenced Apr 24, 2025
Closed
Closed
@k8s-ci-robot k8s-ci-robot merged commit 38ad2e1 into kubernetes:master Apr 25, 2025
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Apr 25, 2025
@BenTheElder BenTheElder deleted the mark-yaml-unwanted branch April 25, 2025 00:22
@BenTheElder BenTheElder mentioned this pull request Apr 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims dims left review comments

@sttts sttts Awaiting requested review from sttts

@thockin thockin Awaiting requested review from thockin

Assignees

@dims dims

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
3 participants
@BenTheElder @k8s-ci-robot @dims