Thanks to visit codestin.com
Credit goes to github.com

Skip to content

enable dep-approvers for staging go.mod/go.sum #131456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2025
Merged

enable dep-approvers for staging go.mod/go.sum #131456

merged 1 commit into from
Apr 25, 2025

Conversation

BenTheElder
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

I think this will finally let dep-approvers that are not inherently owners of all of staging/ actually approve dependency updates. It does not grant permission over files other than go.mod/go.sum in staging.

Follows #131452 (comment)
NOTE: to use filters, all entries must be under filters https://go.k8s.io/owners/#filters
NOTE: we have no_parent_owners used heavily, so specfically OWNERS applying to go.mod/go.sum needed updating. Other more deeply nested or non-dependency management directories do not need this.

I updated staging/src/OWNERS and staging/src/k8s.io/*/OWNERS (first level). Only where no_parent_owners is enabled. We could add it to all of staging/src/k8s.io/*/OWNERS but that's unnecessary unless they add no_parent_owners (which would be relative to staging/src/OWNERS which is already no_parent_owners) and I want to make sure this is working first anyhow. Only a few staging repos do this currently.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/sig architecture
/area code-organization

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. area/code-organization Issues or PRs related to kubernetes code organization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet labels Apr 24, 2025
@k8s-ci-robot k8s-ci-robot requested review from cici37 and kannon92 April 24, 2025 22:43
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 24, 2025
@BenTheElder BenTheElder mentioned this pull request Apr 24, 2025
Merged
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 24, 2025
@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 24, 2025
@BenTheElder
Copy link
Member Author

/cc @dims

@k8s-ci-robot k8s-ci-robot requested a review from dims April 24, 2025 22:48
@BenTheElder BenTheElder mentioned this pull request Apr 24, 2025
Merged
@BenTheElder
Copy link
Member Author

/cc @liggitt

@k8s-ci-robot k8s-ci-robot requested a review from liggitt April 24, 2025 22:53
@BenTheElder
Copy link
Member Author

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Apr 24, 2025
@dims
Copy link
Member

dims commented Apr 24, 2025

/approve
/lgtm

/assign @liggitt

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ca5652f74b1d4e61cd628b5fafd2ff325433b804

@BenTheElder
enable dep-approvers for staging go.mod/go.sum
187b43d 
NOTE: to use filters, _all_ entries must be under filters https://go.k8s.io/owners/#filters
@BenTheElder BenTheElder force-pushed the staging-dep-approvers branch from aa318cf to 187b43d Compare April 25, 2025 00:17
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025
@BenTheElder
Copy link
Member Author

yamlfmt was failing on an extra newline at the end of a file, ran hack/update-yamfmt.sh which just dropped that one newline.

@dims
Copy link
Member

dims commented Apr 25, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a7076d7bd49c14554fe3c10929a153d4136375db

@liggitt
Copy link
Member

liggitt commented Apr 25, 2025

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit 616d6d4 into kubernetes:master Apr 25, 2025
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.34 milestone Apr 25, 2025
@BenTheElder BenTheElder deleted the staging-dep-approvers branch April 25, 2025 02:32
@BenTheElder
Copy link
Member Author

This works!
Screenshot 2025-04-24 at 7 50 11 PM
tested on #131444

FYI @kubernetes/dep-approvers, you can actually approve dependency changes now, remember to follow the guidelines:

https://github.com/kubernetes/community/blob/b3de0387c5ad512a60198728f46150fed692d7ff/contributors/devel/sig-architecture/godep.md#reviewing-and-approving-dependency-changes

(also wow we should update the non-dependency review bits ... we haven't used godep for a long time)

@liggitt
Copy link
Member

liggitt commented Apr 25, 2025

The guidelines are actually at https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/vendor.md

@BenTheElder
Copy link
Member Author

BenTheElder commented Apr 25, 2025 •
edited
Loading

We should probably delete the old godep.md, the review section is so close that I missed this 🙈

... I swear I take far more time reading dependency diffs than digging up links 😅

@BenTheElder
Copy link
Member Author

This document only applies to Kubernetes 1.14.x and earlier,
and should be removed once Kubernetes 1.14.x is no longer supported.

... lol
kubernetes/community#8436

@dims
Copy link
Member

dims commented Apr 25, 2025

thanks @BenTheElder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cici37 cici37 Awaiting requested review from cici37

@kannon92 kannon92 Awaiting requested review from kannon92

@dims dims Awaiting requested review from dims

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@dims dims

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-organization Issues or PRs related to kubernetes code organization area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
4 participants
@BenTheElder @k8s-ci-robot @dims @liggitt