Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update to spf13/pflag to prevent CI break #133823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2025
Merged

Update to spf13/pflag to prevent CI break #133823

merged 2 commits into from
Sep 1, 2025

Conversation

dims
Copy link
Member

@dims dims commented Sep 1, 2025 •
edited
Loading

Fix for #133809

There was a breaking change in pflags 1.0.8, which was fixed in 1.0.9:
spf13/pflag@v1.0.8...v1.0.9

We could do nothing and CI will pick up 1.0.9, but i'd prefer us to update to 1.0.9 to prevent any users of our libraries to pick the fixed/updated version (and not let them pick the broken 1.0.8 by mistake)

What type of PR is this?

/kind bug
/kind failing-test

What this PR does / why we need it:

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 1, 2025
@k8s-ci-robot k8s-ci-robot added area/apiserver area/cloudprovider area/code-generation area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. approved Indicates a PR has been approved by an approver from all required OWNERS files. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 1, 2025
@k8s-ci-robot k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Sep 1, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG CLI Sep 1, 2025
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Sep 1, 2025
@dims dims mentioned this pull request Sep 1, 2025
Merged
@jpmcb
Copy link
Member

jpmcb commented Sep 1, 2025

I went ahead and cut a v1.10.0 of Cobra which consumes pflag v1.0.8 but should mask the breaking change and still work with this PR

https://github.com/spf13/cobra/releases/tag/v1.10.0

@dims not sure if you want to include the new cobra to achieve something like:

github.com/spf13/cobra v1.10.0
github.com/spf13/pflag v1.0.9

@enj enj moved this to Needs Triage in SIG Auth Sep 1, 2025
@dims
Copy link
Member Author

dims commented Sep 1, 2025

I went ahead and cut a v1.10.0 of Cobra

@jpmcb sounds good! added a commit for cobra as well.

soltysh
soltysh approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@github-project-automation github-project-automation bot moved this from Needs Triage to In Progress in SIG Instrumentation Sep 1, 2025
@github-project-automation github-project-automation bot moved this from Triage to Needs Approver in SIG Node: code and documentation PRs Sep 1, 2025
@github-project-automation github-project-automation bot moved this from Triage to PRs - Needs Approver in SIG Node CI/Test Board Sep 1, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to In Review in SIG Auth Sep 1, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 328c0052a61915a8aea6af3878b6daf11cddf658

@soltysh
Copy link
Contributor

soltysh commented Sep 1, 2025

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 1, 2025
jpmcb
jpmcb approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@jpmcb jpmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, jpmcb, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@soltysh
Copy link
Contributor

soltysh commented Sep 1, 2025

Looks like a temporary glitch
/test pull-kubernetes-integration

@k8s-ci-robot k8s-ci-robot merged commit 80b8c7b into kubernetes:master Sep 1, 2025
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Sep 1, 2025
@github-project-automation github-project-automation bot moved this from PRs - Needs Approver to Done in SIG Node CI/Test Board Sep 1, 2025
@github-project-automation github-project-automation bot moved this from Needs Approver to Done in SIG Node: code and documentation PRs Sep 1, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in SIG CLI Sep 1, 2025
@github-project-automation github-project-automation bot moved this from In Review to Closed / Done in SIG Auth Sep 1, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in SIG Instrumentation Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@alexzielenski alexzielenski Awaiting requested review from alexzielenski

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

+1 more reviewer

@jpmcb jpmcb jpmcb approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@soltysh soltysh

@BenTheElder BenTheElder

@liggitt liggitt

@jpmcb jpmcb

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver area/cloudprovider area/code-generation area/code-organization/future-dependencies Issues related to upcoming dependency or golang updates area/code-organization Issues or PRs related to kubernetes code organization area/dependency Issues or PRs related to dependency changes area/kube-proxy area/kubectl area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Archived in project
SIG Auth
Status: Closed / Done
SIG CLI
Status: Done
SIG Instrumentation
Status: Done
SIG Node CI/Test Board
Status: Done
SIG Node: code and documentation PRs
Status: Done
Milestone
v1.35
Development

Successfully merging this pull request may close these issues.
6 participants
@dims @jpmcb @k8s-ci-robot @soltysh @BenTheElder @liggitt