Second attempt at GCE tokens behavior to new format #13594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cjcullen I'm attempting to guard this on the environment variables passed in, so that we don't have the breakage in CI that we were expecting/got last night. |
|
GCE e2e build/test passed for commit 219a1fa. |
|
Labelling this PR as size/S |
|
I don't think we need to version guard this. That introduces extra cruft that we will immediately want to take out. Let's just manage the coordination a little better :). |
|
(And by let's, I mostly mean that I shouldn't have left the LGTM on overnight) |
|
@cjcullen Ack. |
|
GCE e2e build/test passed for commit 5936d0fb181048596cea0967e53efa12711fe971. |
|
GCE e2e build/test passed for commit 219a1fa. |
|
LGTM. |
ghost
pushed a commit
that referenced
this pull request
Sep 4, 2015
Second attempt at GCE tokens behavior to new format
zmerlynn
added a commit
that referenced
this pull request
Sep 10, 2015
…3594-upstream-release-1.0 Automated cherry pick of #13594
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Round two of #13449.