[InPlacePodVerticalScaling] Support in-place pod resize of non-sidecar initContainers#137352
[InPlacePodVerticalScaling] Support in-place pod resize of non-sidecar initContainers#137352natasha41575 wants to merge 4 commits intokubernetes:masterfrom
Conversation
|
Skipping CI for Draft Pull Request. |
|
/test all |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: natasha41575 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| } | ||
| if !m.computePodResizeAction(ctx, pod, i, true, status, changes) { | ||
| // computePodResizeAction updates 'changes' if resize policy requires restarting this container | ||
| break |
There was a problem hiding this comment.
I think the diff view makes it hard to tell what was changed here. I just moved this outside of the if podutil.IsRestartableInitContainer block
|
@natasha41575: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Support in-place pod resize of non-sidecar initContainers.
This is a pretty straightforward change. The machinery is more or less all there already so it's mostly a matter of relaxing the validation checks at the various layers.
The commits:
RestartPolicythat can be defined at the pod-level, and is applicable only when a container does not define its ownRestartPolicy. There is currently a validation check that ensures that a ResizePolicy for a container cannot beRestartRequiredof the pod-level restart policy isNever. Analogously, I have added a validation check to ensure that a ResizePolicy for a container cannot beRestartRequiredof that container's restart policy isNever.Special notes for your reviewer:
Does this PR introduce a user-facing change?
Leaving as a draft while I run a few more manual tests and walk through the actuation logic more carefully