cpumanager: Replace cpuset.CPUSet{} with cpuset.New() for proper initialization#137355
cpumanager: Replace cpuset.CPUSet{} with cpuset.New() for proper initialization#137355lukaszwojciechowski wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @lukaszwojciechowski. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This patch replaces direct struct initialization cpuset.CPUSet{} with
cpuset.New() to ensure the internal map is properly initialized.
While most CPUSet methods work correctly without this change, the Equals
method uses reflect.DeepEqual which returns false when comparing CPUSet
instances where one has a nil internal map and the other has an initialized
(empty) map. This can lead to unexpected false negatives in equality checks.
For example, the following comparison would incorrectly return false:
cpuset.CPUSet{}.Equals(cpuset.New())
This change ensures consistent behavior across all CPUSet operations.
Signed-off-by: Lukasz Wojciechowski <[email protected]>
52af9ec to
48eecb3
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: lukaszwojciechowski The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR replaces direct struct initialization cpuset.CPUSet{} with cpuset.New() to ensure the internal map is properly initialized.
While most CPUSet methods work correctly without this change, the Equals method uses reflect.DeepEqual which returns false when comparing CPUSet instances where one has a nil internal map and the other has an initialized
(empty) map. This can lead to unexpected false negatives in equality checks.
For example, the following comparison would incorrectly return false:
This change ensures consistent behavior across all CPUSet operations.
Which issue(s) this PR is related to:
N/A
Special notes for your reviewer:
Does this PR introduce a user-facing change?
NONE
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: