Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add a cloud-provider hook to scrub DNS for pods #16219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2015
Merged

Add a cloud-provider hook to scrub DNS for pods #16219

merged 1 commit into from
Oct 26, 2015

Conversation

thockin
Copy link
Member

@thockin thockin commented Oct 24, 2015

GCE needs this hook and it seems general enough to include.

@thockin
Add a cloud-provider hook to scrub DNS for pods
42c7fec 
GCE needs this hook and it seems general enough to include.
@k8s-bot
Copy link

k8s-bot commented Oct 24, 2015

GCE e2e/unit/integration build/test failed for commit 42c7fec.

@thockin
Copy link
Member Author

thockin commented Oct 24, 2015

Related: internal b/25155987

Fixes #15917

Needs CP into 1.0 and 1.1

@thockin thockin added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Oct 24, 2015
@thockin thockin added this to the v1.1 milestone Oct 24, 2015
@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 24, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/L

@thockin
Copy link
Member Author

thockin commented Oct 24, 2015

@k8s-bot test this

@k8s-bot
Copy link

k8s-bot commented Oct 24, 2015

GCE e2e build/test failed for commit 42c7fec.

@j3ffml
Copy link
Contributor

j3ffml commented Oct 24, 2015

Sorry about failing tests. I broke e2e job trying to add in unit/integration. Should be working now. @k8s-bot test this

@k8s-bot
Copy link

k8s-bot commented Oct 24, 2015

GCE e2e test build/test passed for commit 42c7fec.

@thockin thockin assigned ArtfulCoder and unassigned brendandburns Oct 26, 2015
@thockin
Copy link
Member Author

thockin commented Oct 26, 2015

Need a review on this ASAP so I can CP this for 1.0 and 1.1

@ArtfulCoder
Copy link
Contributor

LGTM

few clarifying Qs:

  1. so it seems that we want to ensure that we respect ClusterFirst dnsPolicy under all scenarios, hence its appended after the scrub call ?
  2. if resolv.conf flag == "", kubelet does the right thing and does not even invoke scrubDNS ?

We need to update the DNS e2e so that it reads /etc/resolv.conf and ensures that the count is under 6.
but no need to block this PR on e2e..

@ArtfulCoder ArtfulCoder added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2015
@thockin
Copy link
Member Author

thockin commented Oct 26, 2015

@k8s-bot unit test this please

@thockin
Copy link
Member Author

thockin commented Oct 26, 2015

@ArtfulCoder good call on the e2e, but yeah, let's not block this.

@j3ffml
Copy link
Contributor

j3ffml commented Oct 26, 2015

Please ignore the red x on "Jenkins GCE e2e/unit/integration". That was from a broken iteration of the pr builder.

@j3ffml
Copy link
Contributor

j3ffml commented Oct 26, 2015

@k8s-oncall please manually merge (red x is not relevant, actual tests are passing).

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@lavalamp
Copy link
Contributor

e2e has hit #15800

@lavalamp
Copy link
Contributor

Manually merging on account of known flake.

lavalamp added a commit that referenced this pull request Oct 26, 2015
@lavalamp
Merge pull request #16219 from thockin/resolvconf-filter
e42f5af 
Add a cloud-provider hook to scrub DNS for pods
@lavalamp lavalamp merged commit e42f5af into kubernetes:master Oct 26, 2015
@k8s-bot
Copy link

k8s-bot commented Oct 26, 2015

GCE e2e build/test failed for commit 42c7fec.

@zmerlynn zmerlynn mentioned this pull request Oct 26, 2015
Merged
ikehz pushed a commit that referenced this pull request Oct 26, 2015
Merge pull request #16297 from thockin/automated-cherry-pick-of-#1621…
ffd8dd5 
…9-upstream-release-1.0

Automated cherry pick of #16219 upstream release 1.0
@ikehz ikehz mentioned this pull request Oct 27, 2015
Merged
k8s-github-robot referenced this pull request Oct 27, 2015
Merge pull request #16298 from thockin/automated-cherry-pick-of-#1621…
8566fea 
…9-upstream-release-1.1

Auto commit by PR queue bot
@thockin thockin deleted the resolvconf-filter branch November 14, 2015 02:47
shyamjvs referenced this pull request in shyamjvs/kubernetes Dec 1, 2016
Merge pull request kubernetes#16298 from thockin/automated-cherry-pic…
cffe93b 
…k-of-#16219-upstream-release-1.1

Auto commit by PR queue bot
shouhong referenced this pull request in shouhong/kubernetes Feb 14, 2017
Merge pull request kubernetes#16298 from thockin/automated-cherry-pic…
1411eaa 
…k-of-#16219-upstream-release-1.1

Auto commit by PR queue bot
dims pushed a commit to dims/kubernetes that referenced this pull request Feb 8, 2018
@lavalamp
Merge pull request kubernetes#16219 from thockin/resolvconf-filter
16483ca 
Add a cloud-provider hook to scrub DNS for pods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ArtfulCoder ArtfulCoder

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
9 participants
@thockin @k8s-bot @k8s-github-robot @j3ffml @ArtfulCoder @lavalamp @k8s-teamcity-mesosphere @googlebot @brendandburns