Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Validate pod spec.nodeName #17973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2015
Merged

Validate pod spec.nodeName #17973

merged 1 commit into from
Dec 5, 2015

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Nov 30, 2015

Ensure pod nodeName is well formed

@liggitt
Copy link
Member Author

liggitt commented Nov 30, 2015

cc @fabianofranz

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2015
@fabianofranz fabianofranz mentioned this pull request Nov 30, 2015
Merged
@deads2k
Copy link
Contributor

deads2k commented Nov 30, 2015

unit test.

@k8s-bot
Copy link

k8s-bot commented Nov 30, 2015

GCE e2e test build/test passed for commit 96ed149198f1f76ab8d7b98d515bbc3267008516.

@k8s-bot
Copy link

k8s-bot commented Nov 30, 2015

GCE e2e test build/test passed for commit b6f4925bbb7e85b3615fa0afd40a760a526a99ca.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-bot
Copy link

k8s-bot commented Nov 30, 2015

GCE e2e test build/test passed for commit ef7c4f661b46ba57b8f759eb2fc3b24280654ecd.

@fabianofranz
Copy link
Contributor

LGTM

@k8s-bot
Copy link

k8s-bot commented Nov 30, 2015

GCE e2e test build/test passed for commit 062d2758087adbdafcaec50be42f28ec4f3b721b.

@deads2k
Copy link
Contributor

deads2k commented Nov 30, 2015

lgtm

@deads2k deads2k added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 30, 2015
@k8s-github-robot
Copy link

Continuous integration appears to have missed, closing and re-opening to trigger it

This was referenced Nov 30, 2015
Merged
Merged
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 2, 2015
@liggitt liggitt force-pushed the validate_node_name branch from 062d275 to b7af8ee Compare December 2, 2015 18:30
@liggitt
Copy link
Member Author

liggitt commented Dec 2, 2015

rebased

@liggitt liggitt removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2015
@k8s-bot
Copy link

k8s-bot commented Dec 2, 2015

GCE e2e test build/test passed for commit b7af8ee84a11af1792c61a68067c427249964491.

@k8s-bot
Copy link

k8s-bot commented Dec 2, 2015

GCE e2e test build/test passed for commit b7af8ee84a11af1792c61a68067c427249964491.

gmarek pushed a commit that referenced this pull request Dec 3, 2015
Merge pull request #17985 from liggitt/automated-cherry-pick-of-#1797…
7cf7c4d 
…3-upstream-release-1.1

Automated cherry pick of #17973
@k8s-github-robot
Copy link

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

@k8s-bot
Copy link

k8s-bot commented Dec 4, 2015

GCE e2e build/test failed for commit b7af8ee84a11af1792c61a68067c427249964491.

brendandburns added a commit that referenced this pull request Dec 5, 2015
@brendandburns
Merge pull request #17984 from liggitt/automated-cherry-pick-of-#1797…
362a6c0 
…3-upstream-release-1.0

Automated cherry pick of #17973
@liggitt
Copy link
Member Author

liggitt commented Dec 5, 2015

@k8s-bot test this

@k8s-bot
Copy link

k8s-bot commented Dec 5, 2015

GCE e2e build/test failed for commit b7af8ee84a11af1792c61a68067c427249964491.

@liggitt liggitt force-pushed the validate_node_name branch from b7af8ee to 7d10fd3 Compare December 5, 2015 16:34
@liggitt
Copy link
Member Author

liggitt commented Dec 5, 2015

updated for fieldPath validation change

@liggitt liggitt added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 5, 2015
@k8s-github-robot
Copy link

@k8s-bot ok to test
@k8s-bot test this

pr builder appears to be missing, activating due to 'lgtm' label.

@k8s-github-robot
Copy link

Travis continuous integration appears to have missed, closing and re-opening to trigger it

@k8s-bot
Copy link

k8s-bot commented Dec 5, 2015

GCE e2e build/test failed for commit 7d10fd3.

@k8s-bot
Copy link

k8s-bot commented Dec 5, 2015

GCE e2e test build/test passed for commit 7d10fd3.

@liggitt
Copy link
Member Author

liggitt commented Dec 5, 2015

@k8s-bot unit test this

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented Dec 5, 2015

GCE e2e test build/test passed for commit 7d10fd3.

@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Dec 5, 2015
Merge pull request #17973 from liggitt/validate_node_name
fc92833 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit fc92833 into kubernetes:master Dec 5, 2015
@liggitt liggitt deleted the validate_node_name branch December 7, 2015 15:44
@ikehz ikehz added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 9, 2015
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#17985 from liggitt/automated-cherry-pic…
d7c781b 
…k-of-#17973-upstream-release-1.1

Automated cherry pick of kubernetes#17973
shouhong pushed a commit to shouhong/kubernetes that referenced this pull request Feb 14, 2017
Merge pull request kubernetes#17985 from liggitt/automated-cherry-pic…
7562963 
…k-of-#17973-upstream-release-1.1

Automated cherry pick of kubernetes#17973
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brendandburns brendandburns

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@liggitt @k8s-github-robot @deads2k @k8s-bot @fabianofranz @k8s-teamcity-mesosphere @ikehz @googlebot @brendandburns @eparis