-
Notifications
You must be signed in to change notification settings - Fork 40.7k
Configure upgrade jobs from 1.0 on release-1.0 #18028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure upgrade jobs from 1.0 on release-1.0 #18028
Conversation
Labelling this PR as size/L |
GCE e2e build/test failed for commit 4873bd7. |
GCE e2e build/test failed for commit cdc823d. |
# Configurations for step2, step4, and step6 live in the current release | ||
# branch. | ||
|
||
kubernetes-upgrade-gke-1.0-release-step1-deploy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as in #18029, I really don't like "release" in this name. wonder if we can find something better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"current"? I was going to make it "current-release", but that felt wordy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we expect these jobs will always be upgrading to 1.1? or do we only care about upgrading from 1.0 to the latest release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. Once 1.2 is the current release, we'll move them to 1.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er, that was unclear. We do not expect these jobs always to upgrade to 1.1; we only care about upgrading from 1.0 to current release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to "current-release".
GCE e2e build/test failed for commit 8806428. |
lgtm |
Automatic merge from submit-queue |
Auto commit by PR queue bot
lgtm2 |
This includes an (edited) cherry-pick of #17746 plus configs for upgrade jobs that drive from
release-1.0
.