Change the gce constant for session affinity to have the capitalization shown in the documentation #18365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shown in the documentation. Fixes kubernetes#18347
|
Labelling this PR as size/XS |
|
LGTM |
|
need a prio merge or ok to queue? |
|
LGTM |
|
@thockin: Not yet. I can slap it in if needed, but we're trying to get the picky service changed first. |
|
@thockin, I would say let's merge ASAP, I think that may be the fastest way to run all the tests against it. |
zmerlynn
added a commit
that referenced
this pull request
Dec 8, 2015
Change the gce constant for session affinity to have the capitalization shown in the documentation
This was referenced Dec 8, 2015
|
GCE e2e build/test failed for commit 2ecf504. |
roberthbailey
added a commit
that referenced
this pull request
Dec 8, 2015
…-#18365-upstream-release-1.1 Automated cherry pick of #18365 on release-1.1
roberthbailey
added a commit
that referenced
this pull request
Dec 8, 2015
…-#18365-upstream-release-1.0 Automated cherry pick of #18365 on release-1.0
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ry-pick-of-#18365-upstream-release-1.1 Automated cherry pick of kubernetes#18365 on release-1.1
shouhong
pushed a commit
to shouhong/kubernetes
that referenced
this pull request
Feb 14, 2017
…ry-pick-of-#18365-upstream-release-1.1 Automated cherry pick of kubernetes#18365 on release-1.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(hopefully) Fixes #18347
/cc @a-robinson @thockin @zmerlynn