Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Addresses vSphere Volume Attach limits#29881

Merged
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
dagnello:vsphere-volume-limit-bug
Aug 3, 2016
Merged

Addresses vSphere Volume Attach limits#29881
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
dagnello:vsphere-volume-limit-bug

Conversation

@dagnello
Copy link
Copy Markdown
Contributor

@dagnello dagnello commented Aug 1, 2016 •
edited by k8s-oncall
Loading

This PR resolves bug #29878.

This change is Reviewable

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

4 similar comments
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 1, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Aug 1, 2016
@dagnello dagnello force-pushed the vsphere-volume-limit-bug branch from 10360b3 to c82a790 Compare August 1, 2016 21:42
@dagnello
Copy link
Copy Markdown
Contributor Author

dagnello commented Aug 1, 2016

@mikedanese can I get release 1.3 on this PR? It addresses a bug fixes related to 1.3 release. Would like to get this resolved in the next 1.3.x tag.

@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2016
@mikedanese
Copy link
Copy Markdown
Member

mikedanese commented Aug 2, 2016

@k8s-bot ok to test

@mikedanese
Copy link
Copy Markdown
Member

mikedanese commented Aug 2, 2016

cc @abithap @dkalleg @imkin

@dkalleg
Copy link
Copy Markdown
Contributor

dkalleg commented Aug 2, 2016

@mikedanese Tested and works as advertised, lgtm

@dagnello
vSphere Volume Attach limit bug
19642aa 
- Cannot attach scsi devices to slot kubernetes#7
- Limit of 4 scsi controllers per vm MAX
@dagnello dagnello force-pushed the vsphere-volume-limit-bug branch from c82a790 to 19642aa Compare August 2, 2016 21:49
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 2, 2016

GCE e2e build/test passed for commit 19642aa.

@mikedanese mikedanese added lgtm "Looks good to me", indicates that a PR is ready to be merged. cherrypick-candidate labels Aug 3, 2016
@mikedanese mikedanese added this to the v1.3 milestone Aug 3, 2016
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2016
@mikedanese mikedanese changed the title Addresses vSphere Volume Limit Attach limits Addresses vSphere Volume Attach limits Aug 3, 2016
@mikedanese mikedanese added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Aug 3, 2016
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 3, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 3, 2016

GCE e2e build/test passed for commit 19642aa.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 3, 2016

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 7c32667 into kubernetes:master Aug 3, 2016
@fabioy fabioy added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 5, 2016
@fabioy
Copy link
Copy Markdown
Contributor

fabioy commented Aug 5, 2016

@dagnello Cherrypick approved. Please create a cherrypick PR. Thanks.

@fabioy fabioy mentioned this pull request Aug 18, 2016
Merged
k8s-github-robot pushed a commit that referenced this pull request Aug 25, 2016
Merge pull request #30891 from fabioy/automated-cherry-pick-of-#29881…
985dcfb 
…-upstream-release-1.3

Automatic merge from submit-queue

Automated cherry pick of #29881

Cherry pick of #29881 on release-1.3.
@k8s-cherrypick-bot
Copy link
Copy Markdown

k8s-cherrypick-bot commented Aug 25, 2016

Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

@dagnello dagnello mentioned this pull request Sep 2, 2016
Closed
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
Merge pull request kubernetes#30891 from fabioy/automated-cherry-pick…
c5c48f8 
…-of-#29881-upstream-release-1.3

Automatic merge from submit-queue

Automated cherry pick of kubernetes#29881

Cherry pick of kubernetes#29881 on release-1.3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mikedanese mikedanese

Labels

cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.3

Development

Successfully merging this pull request may close these issues.

8 participants

@dagnello @k8s-bot @mikedanese @dkalleg @k8s-github-robot @fabioy @k8s-cherrypick-bot @googlebot