Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fixes invalid null selector issue in sysdig example yaml#31393

Merged
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
StackPointCloud:master
Sep 5, 2016
Merged

fixes invalid null selector issue in sysdig example yaml#31393
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
StackPointCloud:master

Conversation

@baldwinSPC
Copy link
Copy Markdown

@baldwinSPC baldwinSPC commented Aug 24, 2016 •
edited by k8s-oncall
Loading

What this PR does / why we need it:

Using the file DaemonSet yaml found in the example repo you get the following error upon import:

$ kubectl create -f sysdig.yml
The DaemonSet "sysdig-agent" is invalid.
spec.template.metadata.labels: Invalid value: null: `selector` does not match template `labels`

This PR fixes this issue.

Which issue this PR fixes (optional, in fixes #<issue number>(, #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

  • Corrected name label metadata for Sysdig example.

This change is Reviewable

fixes invalid null selector issue
941e872 
Before this change this example would result in: 

$ kubectl create -f sysdig.yml
The DaemonSet "sysdig-agent" is invalid.
spec.template.metadata.labels: Invalid value: null: `selector` does not match template `labels`
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 24, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

6 similar comments
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 24, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 24, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 25, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 25, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 25, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 25, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Aug 25, 2016
@brendandburns brendandburns added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 25, 2016
@brendandburns
Copy link
Copy Markdown
Contributor

brendandburns commented Aug 25, 2016

LGTM.

@k8s-bot ok to test

Thanks for the PR.

@brendandburns brendandburns added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Aug 25, 2016
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Sep 2, 2016

GCE e2e build/test passed for commit 941e872.

@goltermann goltermann added this to the v1.4 milestone Sep 5, 2016
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 5, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Sep 5, 2016

GCE e2e build/test passed for commit 941e872.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 5, 2016

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit f06dc32 into kubernetes:master Sep 5, 2016
k8s-ci-robot added a commit that referenced this pull request Feb 10, 2022
@k8s-ci-robot
Merge pull request #107691 from SubhasmitaSw/issue_31393
71977b6 
Removed references to Docker in Kubernetes API #31393
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brendandburns brendandburns

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.4

Development

Successfully merging this pull request may close these issues.

6 participants

@baldwinSPC @k8s-bot @brendandburns @k8s-github-robot @googlebot @goltermann