Thanks to visit codestin.com
Credit goes to github.com

Skip to content

vendor: update github.com/coreos/go-oidc client package#31564

Merged
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
ericchiang:update-go-oidc
Sep 12, 2016
Merged

vendor: update github.com/coreos/go-oidc client package#31564
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
ericchiang:update-go-oidc

Conversation

@ericchiang
Copy link
Copy Markdown
Contributor

@ericchiang ericchiang commented Aug 26, 2016

This change updates the github.com/coreos/go-oidc package to it's latest commit
(since we don't version that package).

Notable changes:

cc @kubernetes/sig-auth


This change is Reviewable

This change updates the github.com/coreos/go-oidc package.

Notable changes:

- Throw out JWTs with invalid claims early (coreos/go-oidc#97, brougt up in kubernetes#30457)
- Remove the capnslog dependency (coreos/go-oidc#95)
- Support for Azure AD oddities (coreos/go-oidc#87)
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Aug 26, 2016
@bgrant0607 bgrant0607 assigned erictune and unassigned bgrant0607 Aug 27, 2016
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Aug 30, 2016

@ericchiang post-1.4 I presume? Bumping dependencies seems fine, but I'd prefer to do it at the start of a cycle.

RefreshToken string `json:"refresh_token"`
Scope string `json:"scope"`
State string `json:"state"`
ExpiresIn json.Number `json:"expires_in"` // Azure AD returns string
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course they would. Surely something like https://tools.ietf.org/html/rfc6749#appendix-A.14 saying 1*DIGIT is just a suggestion.

@liggitt does this affect us?

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Aug 30, 2016

lgtm post-1.4

@ericchiang
Copy link
Copy Markdown
Contributor Author

yes, please mark as 1.5

@deads2k deads2k added this to the v1.5 milestone Aug 30, 2016
@deads2k deads2k added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 30, 2016
@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Aug 30, 2016

I marked for release note because of the active directory bit.

@k8s-github-robot
Copy link
Copy Markdown

@ericchiang
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Sep 12, 2016

GCE e2e build/test passed for commit 16edba2.

@k8s-github-robot
Copy link
Copy Markdown

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Sep 12, 2016

GCE e2e build/test passed for commit 16edba2.

@k8s-github-robot
Copy link
Copy Markdown

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 32a3296 into kubernetes:master Sep 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants