Thanks to visit codestin.com
Credit goes to github.com

Skip to content

kubectl edit: Do not add warning header if ftype is json.#31685

Merged
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
jellonek:jell/29524
Sep 6, 2016
Merged

kubectl edit: Do not add warning header if ftype is json.#31685
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
jellonek:jell/29524

Conversation

@jellonek
Copy link
Copy Markdown
Contributor

@jellonek jellonek commented Aug 30, 2016 •
edited by pwittrock
Loading

This PR blocks adding warning header if kubectl edit is used with -o json option.
Fixed header contains comment (what is not supported by json standard) what can break utilities which are using libraries that conforms with http://www.ietf.org/rfc/rfc7159.txt

fixes #29524

/cc @pwittrock

Removed comments in json config when using kubectl edit with -o json

This change is Reviewable

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

6 similar comments
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Aug 30, 2016
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

1 similar comment
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Aug 30, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message will repeat several times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

@pwittrock
Copy link
Copy Markdown
Member

pwittrock commented Aug 30, 2016

ok to test

@pwittrock pwittrock added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2016
@pwittrock
Copy link
Copy Markdown
Member

pwittrock commented Aug 30, 2016

@jellonek Thanks for fixing this!

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Aug 30, 2016
@pwittrock
Copy link
Copy Markdown
Member

pwittrock commented Aug 30, 2016

@jellonek FYI, we are in code freeze preparing for the upcoming release. This will go in once we upon up master again. ~1 week.

@pwittrock pwittrock added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Aug 30, 2016
@jellonek
Copy link
Copy Markdown
Contributor Author

jellonek commented Aug 31, 2016

Thanx, I'm aware about this.

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Sep 3, 2016

GCE e2e build/test passed for commit d0e59e0.

@goltermann goltermann added this to the v1.4 milestone Sep 5, 2016
@goltermann goltermann removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Sep 5, 2016
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 6, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Sep 6, 2016

GCE e2e build/test passed for commit d0e59e0.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Sep 6, 2016

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 8d00825 into kubernetes:master Sep 6, 2016
@jellonek jellonek deleted the jell/29524 branch April 6, 2017 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pwittrock pwittrock

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.4

Development

Successfully merging this pull request may close these issues.

Editing with -o json returns invalid JSON

6 participants

@jellonek @k8s-bot @pwittrock @k8s-github-robot @googlebot @goltermann