Default HTTP2 on, post fixes from #29001#32231
Conversation
|
GCE e2e build/test passed for commit ed082389331eb4c7319f5eef40b6ae5a2554dc11. |
|
Remind me what this broke last time and why it's ok now. |
|
This looks fine to me. I'll leave it to @gmarek for the final OK. |
|
@timothysc - how urgent it is? We're running last scalability tests on master, so I'd rather wait a day or two until we're finished. Then we'll give it a try and see what happens. |
|
@gmarek no rush.. hoping to flush out for 1.5 |
|
@timothysc - I'm fine with it, but please wait until 1.4 is out. Let's merge it next week. |
|
sgtm. |
|
So were all branched, unless someone objects I was going to apply today. |
|
We have the TLS |
|
@smarterclayton not yet. I suppose we should block on #28742 then. |
|
Can we not set that field also on Go 1.6? I thought it worked on both On Thu, Sep 22, 2016 at 12:51 PM, Timothy St. Clair <
|
|
You can set it on 1.6 too. |
|
i'll update the pr. |
|
@timothysc - we can merge this now, ping me when you'll update it for 1.6. |
ed08238 to
009f877
Compare
|
@gmarek ready. |
|
Jenkins GCI Kubemark GCE e2e failed for commit 009f877. Full PR test history. The magic incantation to run this job again is |
|
Jenkins GCI GKE smoke e2e failed for commit 009f877. Full PR test history. The magic incantation to run this job again is |
|
LGTM FYI @thockin |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
This reverts commit 8cb799c.
Enables HTTP2 on by default post fixes from #29001 for 1.5
NOTE: We are nearing lb connection limits at current thresholds.
/cc @bradfitz @lavalamp @smarterclayton
This change is