Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Default HTTP2 on, post fixes from #29001#32231

Merged
k8s-github-robot merged 2 commits into
kubernetes:masterfrom
timothysc:re-re-http2
Sep 26, 2016
Merged

Default HTTP2 on, post fixes from #29001#32231
k8s-github-robot merged 2 commits into
kubernetes:masterfrom
timothysc:re-re-http2

Conversation

@timothysc
Copy link
Copy Markdown
Contributor

@timothysc timothysc commented Sep 7, 2016

This reverts commit 8cb799c.

Enables HTTP2 on by default post fixes from #29001 for 1.5

NOTE: We are nearing lb connection limits at current thresholds.

/cc @bradfitz @lavalamp @smarterclayton


This change is Reviewable

@timothysc timothysc added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 7, 2016
@timothysc timothysc added this to the v1.5 milestone Sep 7, 2016
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Sep 7, 2016
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Sep 7, 2016

GCE e2e build/test passed for commit ed082389331eb4c7319f5eef40b6ae5a2554dc11.

@krousey
Copy link
Copy Markdown
Contributor

krousey commented Sep 13, 2016

Remind me what this broke last time and why it's ok now.

@timothysc
Copy link
Copy Markdown
Contributor Author

@krousey #29001 has the gory history.

We will likely want to loop in @gmarek before we flip this switch too.

We're starting to enter into hard constraints due to the 1.5 goals of 5k nodes. Without this, we're simply going to start running out of ports.

@krousey
Copy link
Copy Markdown
Contributor

krousey commented Sep 13, 2016

This looks fine to me. I'll leave it to @gmarek for the final OK.

@gmarek
Copy link
Copy Markdown
Contributor

gmarek commented Sep 13, 2016

@timothysc - how urgent it is? We're running last scalability tests on master, so I'd rather wait a day or two until we're finished. Then we'll give it a try and see what happens.

@timothysc
Copy link
Copy Markdown
Contributor Author

@gmarek no rush.. hoping to flush out for 1.5

@wojtek-t
Copy link
Copy Markdown
Member

@timothysc - I'm fine with it, but please wait until 1.4 is out. Let's merge it next week.

@timothysc
Copy link
Copy Markdown
Contributor Author

sgtm.

@timothysc timothysc added release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed release-note-none Denotes a PR that doesn't merit a release note. labels Sep 13, 2016
@timothysc timothysc changed the title Revert "Revert "Follow on for 1.4 to default HTTP2 on by default"" Default HTTP2 on, post fixes from #29001 Sep 13, 2016
@timothysc
Copy link
Copy Markdown
Contributor Author

So were all branched, unless someone objects I was going to apply today.

@timothysc timothysc added the priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. label Sep 22, 2016
@smarterclayton
Copy link
Copy Markdown
Contributor

We have the TLS .NextProtos = ["h2"] thing right?

@timothysc
Copy link
Copy Markdown
Contributor Author

@smarterclayton not yet. I suppose we should block on #28742 then.

@smarterclayton
Copy link
Copy Markdown
Contributor

Can we not set that field also on Go 1.6? I thought it worked on both
versions, but was required for client cert on 1.7?

On Thu, Sep 22, 2016 at 12:51 PM, Timothy St. Clair <
[email protected]> wrote:

@smarterclayton https://github.com/smarterclayton not yet. I suppose we
should block on #28742
#28742 then.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#32231 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABG_pyCn4k2MEQWP27A5ygIHgbohOy47ks5qsrH7gaJpZM4J3Yal
.

@bradfitz
Copy link
Copy Markdown

You can set it on 1.6 too.

@timothysc
Copy link
Copy Markdown
Contributor Author

i'll update the pr.

@gmarek
Copy link
Copy Markdown
Contributor

gmarek commented Sep 26, 2016

@timothysc - we can merge this now, ping me when you'll update it for 1.6.

@timothysc
Copy link
Copy Markdown
Contributor Author

@gmarek ready.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Jenkins GCI Kubemark GCE e2e failed for commit 009f877. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark gci e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Jenkins GCI GKE smoke e2e failed for commit 009f877. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@gmarek
Copy link
Copy Markdown
Contributor

gmarek commented Sep 26, 2016

LGTM

FYI @thockin

@gmarek gmarek added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2016
@k8s-github-robot
Copy link
Copy Markdown

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3efed28 into kubernetes:master Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/awaiting-more-evidence Lowest priority. Possibly useful, but not yet enough support to actually get it done. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants