Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Factor out post-init swagger and OpenAPI routes#32590

Merged
k8s-github-robot merged 2 commits into
kubernetes:masterfrom
sttts:sttts-post-api-routes
Oct 22, 2016
Merged

Factor out post-init swagger and OpenAPI routes#32590
k8s-github-robot merged 2 commits into
kubernetes:masterfrom
sttts:sttts-post-api-routes

Conversation

@sttts
Copy link
Copy Markdown
Contributor

@sttts sttts commented Sep 13, 2016 •
edited by k8s-oncall
Loading

This change is Reviewable

@sttts sttts added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/apiserver labels Sep 13, 2016
@sttts sttts force-pushed the sttts-post-api-routes branch from d18346e to d62e161 Compare September 13, 2016 18:50
@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Sep 13, 2016
@k8s-bot
Copy link
Copy Markdown

k8s-bot commented Sep 13, 2016

GCE e2e build/test passed for commit d62e161.

deads2k
deads2k reviewed Sep 13, 2016
View reviewed changes
Comment thread pkg/genericapiserver/genericapiserver.go
}
if s.enableOpenAPISupport {
s.InstallOpenAPI()
routes.OpenAPI{
Copy link
Copy Markdown
Contributor

@deads2k deads2k Sep 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably know this, but what is this OpenAPI thing?

Copy link
Copy Markdown
Contributor Author

@sttts sttts Sep 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swagger alternative: https://openapis.org/

Copy link
Copy Markdown
Contributor Author

@sttts sttts Sep 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... that's what I thought. Wikipedia: "The OpenAPI Specification (originally known as the Swagger Specification)".

Copy link
Copy Markdown
Contributor

@nikhiljindal nikhiljindal Sep 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes swagger 2.0 is OpenAPI spec which is designed by the Open API initiative (OAI)

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Sep 13, 2016

just a question. lgtm

@nikhiljindal
Copy link
Copy Markdown
Contributor

nikhiljindal commented Sep 13, 2016

cc @mbohlool

@nikhiljindal nikhiljindal added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 13, 2016
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 15, 2016
@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Sep 19, 2016

Blocked right now by unexpected dependencies.

@sttts sttts changed the title Factor out post-init swagger and OpenAPI routes BLOCKED: Factor out post-init swagger and OpenAPI routes Sep 21, 2016
@sttts sttts force-pushed the sttts-post-api-routes branch from d62e161 to 6068c08 Compare September 30, 2016 08:48
@sttts sttts changed the title BLOCKED: Factor out post-init swagger and OpenAPI routes Factor out post-init swagger and OpenAPI routes Sep 30, 2016
@sttts sttts added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Sep 30, 2016
@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Sep 30, 2016

@deads2k unblocked this. ptal

@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 30, 2016
@sttts sttts force-pushed the sttts-post-api-routes branch 5 times, most recently from ace43f8 to 4a629c6 Compare September 30, 2016 18:01
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 30, 2016

Jenkins GKE smoke e2e failed for commit 4a629c6. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Sep 30, 2016

Jenkins Kubemark GCE e2e failed for commit 4a629c6. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@sttts sttts force-pushed the sttts-post-api-routes branch from 29f9e1d to 54a0960 Compare October 19, 2016 13:13
@sttts sttts added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 19, 2016
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 19, 2016

Jenkins GCI GKE smoke e2e failed for commit 54a0960cc46e995be2d4dd4ecaee49120b04c1ac. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-github-robot k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 20, 2016
@sttts sttts force-pushed the sttts-post-api-routes branch from c9caf13 to cfe04db Compare October 21, 2016 11:57
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2016
@sttts sttts added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 21, 2016
@sttts sttts force-pushed the sttts-post-api-routes branch from cfe04db to b239f92 Compare October 21, 2016 13:43
@sttts sttts added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 21, 2016
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 21, 2016

Jenkins unit/integration failed for commit b239f9241a3092e1d107214817dfbb7f08c63331. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@sttts sttts force-pushed the sttts-post-api-routes branch from b239f92 to c7b9db1 Compare October 22, 2016 11:17
@sttts sttts added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Oct 22, 2016
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 22, 2016

Jenkins GCI GCE e2e failed for commit c7b9db1f95c4049394150e44c1616f2c68e7e384. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@sttts sttts force-pushed the sttts-post-api-routes branch from c7b9db1 to cca05af Compare October 22, 2016 11:42
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2016
@sttts sttts added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2016
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Oct 22, 2016

Jenkins verification failed for commit c4b4bbee0fc1d62d299e5d6970d6540e25e7d600. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@sttts sttts force-pushed the sttts-post-api-routes branch from c4b4bbe to 05fcc6b Compare October 22, 2016 12:32
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2016
@sttts sttts added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 22, 2016
@sttts
Copy link
Copy Markdown
Contributor Author

sttts commented Oct 22, 2016

Bazel fun.

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Oct 22, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Oct 22, 2016

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit cab99c7 into kubernetes:master Oct 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@deads2k deads2k

Labels

area/apiserver kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sttts @k8s-bot @deads2k @nikhiljindal @k8s-ci-robot @k8s-github-robot @googlebot