Codestin Search App

errordeveloper · 2016-09-22T09:03:19Z

What this PR does / why we need it:

This PR add alpha version of kubeadm tool, which allows user to boostrap a cluster rather quite easily. This is the initial contribution from @kubernetes/sig-cluster-lifecycle members, who's aim is to build easy-to-use tools that help to operate a cluster throughout its lifetime.

Which issue this PR fixes: a leap towards kubernetes/enhancements#11

Special notes for your reviewer: previously seen by many folks in #31221

Release note:

`kubeadm` (alpha) provides an easy way to securely bootstrap Kubernetes on Linux, see http://kubernetes.io/docs/kubeadm/

This change is

googlebot · 2016-09-22T09:03:26Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

lukemarsden · 2016-09-22T09:06:22Z

I am okay with these commits being contributed to Google.

yoojinl · 2016-09-22T09:12:33Z

I am okay with these commits being contributed to Google.

pires · 2016-09-22T09:16:22Z

I am okay with these commits being contributed to Google.

sttts · 2016-09-22T09:17:30Z

+
+- `--token=<token>`
+
+By default, a token is generated, but if you are to automate cluster deployment, you will want to


indent the paragraph and you get nice alignment with the flag.

sttts · 2016-09-22T09:19:28Z

+By default, `kubeadm` sets `cluster.local` as the cluster DNS domain. If you would like to set a different one, use `--service-dns-domain`.
+
+- `--schedule-workload=<bool>` (default: "false")
+


strange flag name. Why not be more explicit: --master-schedulable

Good question, I am not entierely sure why we ended-up with this exact flag. @lukemarsden might have some background on this.

There was a discussion on sig-cluster-lifecycle about that. We were not certain about the usage of word schedulable so we ended up with schedule-workload.

on balance i think --master-schedulable is better, i'd be happy to change this but let's be quick about it

Also, -S alias would probably make sense. To be very honest, I struggle to spell "schedulable", pronouncing it is even harder. On that note, I am okay to change it, but may be we can think of something a bit better? For example, --accept-workload may be a good one to consider.

+1 to --accept-workload.
I'm not sure about the usage of term master here, because init is run on master, in case if we are fine with term "schedulable" in user facing interface, I would probably just rename it to --schedulable.

--schedule-pods-on-master

Without the word "master" it's not clear to me that this only applies to the master nodes. We are initializing the cluster. So flags might have a cluster-wide influence.

Let's go with --schedule-pods-here.

I'll be looking out for having a reverse one for nodes, cause you might wanna have spare nodes that initially don't take any workload until you turn the knob. I mean: kubeadm join --schedule-pods-here=false.

luxas · 2016-09-22T09:22:48Z

I am okay with these commits being contributed to Google.

sttts · 2016-09-22T09:23:02Z

+
+	cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
+	"k8s.io/kubernetes/pkg/util/flag"
+


~~Ah, there is also a bit of junk down below, I completely forgot to look at this doc, I'll go and cleanup now!~~ (this was in relation to the readme)

sttts · 2016-09-22T09:37:20Z

@@ -0,0 +1,94 @@
+# Kubernetes Cluster Boostrap Made Easy


taimir · 2016-09-22T09:37:31Z

I am okay with these commits being contributed to Google.

errordeveloper · 2016-09-22T10:01:58Z

_Docs: kubernetes/website#1265_

lukemarsden · 2016-09-22T10:40:59Z

+
+By default, when `kubeadm init` runs, a token is generated and revealed in the output. That's the token you should use here.
+
+## User Experience Considerations (move to design doc, when we have one)


let's just delete this section

lukemarsden · 2016-09-22T10:41:36Z

+		"host_pki_path":      "/etc/kubernetes/pki",
+		"host_etcd_path":     "/var/lib/etcd",
+		"hyperkube_image":    "",
+		"discovery_image":    "dgoodwin/kubediscovery:latest", // TODO(phase1): fmt.Sprintf("gcr.io/google_containers/kube-discovery-%s:%s", runtime.GOARCH, "1.0"),


this is blocked on #32203 and getting this image into gcr.io I think

@mikedanese

or we can leave this as-is and do a followup PR once #32203 is ready, that would be fine too IMO

PR is merged, as soon as @mikedanese has pushed the images, update

Could you please confirm exact image with the tag and I'll update this?

The format in the TODO looks correct. I can confirm later.

Doesn't look it's present, I've tried different tags and cannot remember how to list tags. In fact, I am not even sure how to confirm gcr.io/google_containers/kube-apiserver-amd64 exist at all.

@errordeveloper https://gcr.io/v2/google-containers/kube-discovery-amd64/tags/list

I'll include it in my new patch

Thanks @mikedanese!

lukemarsden

couple of review comments

lukemarsden · 2016-09-25T19:51:49Z

Thanks @luxas and everyone else!

luxas · 2016-09-25T19:52:31Z

And no other PRs in SQ! That's great

justinsb · 2016-09-25T20:42:22Z

@k8s-bot gke e2e test this

k8s-ci-robot · 2016-09-25T20:46:18Z

Jenkins verification failed for commit 1cf13343d0c3a7c22b02b095f02be2e0f464ae66. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

mikedanese · 2016-09-26T02:41:48Z

Please drop merge commits.

…gs/pull/33262/kubernetes-pull-verify-all/15586/

lukemarsden · 2016-09-26T08:16:32Z

Please drop merge commits.

Done.

k8s-ci-robot · 2016-09-26T08:51:42Z

Jenkins GCI GKE smoke e2e failed for commit 3a4613d. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

k8s-github-robot · 2016-09-26T08:57:31Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-ci-robot · 2016-09-26T09:12:47Z

Jenkins GKE smoke e2e failed for commit 3a4613d. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

k8s-github-robot · 2016-09-26T09:35:46Z

Automatic merge from submit-queue

errordeveloper · 2016-09-27T21:10:58Z

Mike, do you have any poi gets to docs to confirm that?

On Tue, 27 Sep 2016, 11:53 Mike Danese, [email protected] wrote:

@mikedanese commented on this pull request.

In cmd/kubeadm/app/api/types.go
#33262:
  }
}

Services struct {
CIDR      net.IPNet
DNSDomain string
}

PodNetwork struct {
CIDR net.IPNet
}

CloudProvider string

Schedulable bool
+}
+
+const (

DefaultServiceDNSDomain = "cluster.local"

DefaultServicesCIDRString = "100.64.0.0/12"
Both AWS and Google networks use this range. This is going to cause weird
failures.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#33262, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPWS6gJKEwsWwyigzkctI6F1oMG74_uks5quPWxgaJpZM4KDq18
.

Automatic merge from submit-queue Start tidying kubeadm up **What this PR does / why we need it**: This PR addresses kubernetes#33262 (comment). **Release note**: ```release-note NONE ```

googlebot added the cla: no label Sep 22, 2016

k8s-github-robot assigned thockin Sep 22, 2016

k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Sep 22, 2016

sttts reviewed Sep 22, 2016

View reviewed changes

jbeda mentioned this pull request Sep 22, 2016

Dramatically Simplify Kubernetes Cluster Creation (kubeadm umbrella issue). kubernetes/enhancements#11

Closed

18 tasks

sttts reviewed Sep 22, 2016

View reviewed changes

lukemarsden mentioned this pull request Sep 22, 2016

Do not merge: Kubeadm work in progress #31221

Closed

errordeveloper force-pushed the kubeadm branch from 068d400 to d08bdf9 Compare September 22, 2016 09:33

sttts reviewed Sep 22, 2016

View reviewed changes

Comment thread cmd/kubeadm/README.md Outdated

@@ -0,0 +1,94 @@

# Kubernetes Cluster Boostrap Made Easy

Copy link
Copy Markdown

Contributor

sttts Sep 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bootstrap

lukemarsden reviewed Sep 22, 2016

View reviewed changes

luxas added release-note-experimental and removed release-note-label-needed labels Sep 22, 2016

luxas added this to the v1.5 milestone Sep 22, 2016

luxas assigned jbeda, mikedanese and luxas and unassigned thockin Sep 22, 2016

lukemarsden mentioned this pull request Sep 22, 2016

[WIP] kubeadm and add-on docs kubernetes/website#1265

Merged

errordeveloper force-pushed the kubeadm branch from d0b1e5c to 65ced26 Compare September 23, 2016 06:07

yoojinl mentioned this pull request Sep 23, 2016

Rename flag --schedule-workload to --schedule-pods-here for kubeadm init errordeveloper/kubernetes#19

Merged

luxas removed the cla: no label Sep 25, 2016

googlebot added the cla: no label Sep 25, 2016

luxas removed the cla: no label Sep 25, 2016

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2016

luxas added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2016

k8s-github-robot mentioned this pull request Sep 25, 2016

[k8s.io] Downward API volume should update annotations on modification [Conformance] {E2eNode Suite} #33434

Closed

googlebot added the cla: no label Sep 25, 2016

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2016

luxas and others added 2 commits September 26, 2016 09:13

Update CHANGELOG and gofmt

5157386

fix https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-lo…

3a4613d

…gs/pull/33262/kubernetes-pull-verify-all/15586/

lukemarsden force-pushed the kubeadm branch from c48ee19 to 3a4613d Compare September 26, 2016 08:13

luxas added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed cla: no labels Sep 26, 2016

k8s-github-robot merged commit c19e08e into kubernetes:master Sep 26, 2016

errordeveloper mentioned this pull request Oct 3, 2016

kubeadm refactor token handling #33911

Closed

errordeveloper mentioned this pull request Oct 19, 2016

Start tidying kubeadm up #35119

Merged

davidopp mentioned this pull request Nov 4, 2016

Stop using taint with key=dedicated to mark master node #36272

Closed

errordeveloper deleted the kubeadm branch January 9, 2018 13:45


		- `--token=<token>`

		By default, a token is generated, but if you are to automate cluster deployment, you will want to

		By default, `kubeadm` sets `cluster.local` as the cluster DNS domain. If you would like to set a different one, use `--service-dns-domain`.

		- `--schedule-workload=<bool>` (default: "false")


		cmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
		"k8s.io/kubernetes/pkg/util/flag"


		By default, when `kubeadm init` runs, a token is generated and revealed in the output. That's the token you should use here.

		## User Experience Considerations (move to design doc, when we have one)

Conversation

errordeveloper commented Sep 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Sep 22, 2016

Uh oh!

lukemarsden commented Sep 22, 2016

Uh oh!

yoojinl commented Sep 22, 2016

Uh oh!

pires commented Sep 22, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

errordeveloper Sep 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yoojinl Sep 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luxas commented Sep 22, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

errordeveloper Sep 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taimir commented Sep 22, 2016

Uh oh!

errordeveloper commented Sep 22, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lukemarsden left a comment

Choose a reason for hiding this comment

Uh oh!

lukemarsden commented Sep 25, 2016

Uh oh!

luxas commented Sep 25, 2016

Uh oh!

justinsb commented Sep 25, 2016

errordeveloper commented Sep 22, 2016 •

edited

Loading

errordeveloper Sep 23, 2016 •

edited

Loading

yoojinl Sep 23, 2016 •

edited

Loading

errordeveloper Sep 22, 2016 •

edited

Loading