Codestin Search App

vishh · 2016-09-26T22:30:23Z

Kubelet cannot identify rootfs correctly
For #33444

Enforce Disk based pod eviction with GCI base image in Kubelet

Signed-off-by: Vishnu kannan [email protected]

This change is

…rrectly Signed-off-by: Vishnu kannan <[email protected]>

vishh · 2016-09-26T22:31:32Z

P2 since it needs to be cherry-picked into 1.4 branch soon for stabilizing GCI tests.

dchen1107 · 2016-09-27T15:58:47Z

Checked the new configuration with @dashpole's newly introduced out-of-inode test on gci image, and it works.

LGTM

jessfraz · 2016-10-05T22:48:45Z

@vishh is this something that needs to be in 1.4.1?

vishh · 2016-10-06T00:05:52Z

@jessfraz Ideally yes. I will try to get the tests to pass tomorrow.

jessfraz · 2016-10-06T00:26:11Z

Thanks!!

On Wednesday, October 5, 2016, Vish Kannan [email protected] wrote:

@jessfraz https://github.com/jessfraz Ideally yes. I will try to get
the tests to pass tomorrow.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#33520 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbFOlnT0NXlLQJhpDTO62Wmbx7T7Bks5qxDuQgaJpZM4KHEIO
.

vishh · 2016-10-06T20:54:54Z

@k8s-bot node e2e test this github issue #IGNORE

vishh · 2016-10-06T20:55:06Z

@k8s-bot gke e2e test this github issue #IGNORE

vishh · 2016-10-06T21:29:25Z

@jessfraz Tests are green. 🙏 ing for no flakes.

k8s-ci-robot · 2016-10-06T21:39:23Z

Jenkins GKE smoke e2e failed for commit e7633d8. Full PR test history.

The magic incantation to run this job again is @k8s-bot gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

jessfraz · 2016-10-06T21:53:03Z

i think the submit queue is blocked :(

On Thu, Oct 6, 2016 at 2:40 PM, k8s-ci-robot [email protected]
wrote:

Jenkins GKE smoke e2e failed
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/33520/kubernetes-pull-build-test-e2e-gke/15718/
for commit e7633d8
e7633d8.
Full PR test history http://pr-test.k8s.io/33520.

The magic incantation to run this job again is @k8s-bot gke e2e test this.
Please help us cut down flakes by linking to an open flake issue
https://github.com/kubernetes/kubernetes/issues?q=is:issue+label:kind/flake+is:open
when you hit one in your PR.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#33520 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABYNbGgQ4NMW0a09NLtCI04xkfxGq36Qks5qxWq7gaJpZM4KHEIO
.

k8s-github-robot · 2016-10-06T23:58:17Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2016-10-07T00:37:33Z

Automatic merge from submit-queue

jessfraz · 2016-10-07T03:29:33Z

opened cherrypick here: #34296

#34251-origin-release-1.4 Automatic merge from submit-queue Automated cherry pick of #33520 #34251 origin release 1.4 Cherry pick of #33520 #34251 on release-1.4. #33520: nodefs becomes imagefs on GCI since kubelet cannot identify #34251: Fix nil pointer issue when getting metrics from volume

jessfraz · 2016-10-07T16:48:07Z

cherry-picked to 1.4 in #34296 so removing cherry-pick candidate

…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs

Automatic merge from submit-queue Cadvisor root path configuration This solves #33444 and reverts PR #33520. This takes the root directory and passes it to cadvisor, which sets up the "nodefs" based on the provided path, rather than using "/" as before. This PR is pending on changes in cadvisor, and will not pass tests until those changes are merged, and cadvisor godeps are updated. ```release-note kubelet summary rootfs now refers to the filesystem that contains the Kubelet RootDirectory (var/lib/kubelet) instead of cadvisor's rootfs ( / ), since they may be different filesystems. ```

…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs

…ck-of-#33520-kubernetes#34251-origin-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#33520 kubernetes#34251 origin release 1.4 Cherry pick of kubernetes#33520 kubernetes#34251 on release-1.4. kubernetes#33520: nodefs becomes imagefs on GCI since kubelet cannot identify kubernetes#34251: Fix nil pointer issue when getting metrics from volume

…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs

nodefs becomes imagefs on GCI since kubelet cannot identify rootfs co…

e7633d8

…rrectly Signed-off-by: Vishnu kannan <[email protected]>

googlebot added the cla: yes label Sep 26, 2016

vishh assigned dchen1107 Sep 26, 2016

k8s-oncall unassigned dchen1107 Sep 26, 2016

vishh added this to the v1.4-nonblocking milestone Sep 26, 2016

vishh added release-note Denotes a PR that will be considered when it comes time to generate release notes. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Sep 26, 2016

vishh assigned dchen1107 Sep 26, 2016

k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 26, 2016

dchen1107 added lgtm "Looks good to me", indicates that a PR is ready to be merged. cherrypick-candidate labels Sep 27, 2016

pwittrock modified the milestones: v1.4, v1.4-nonblocking Sep 27, 2016

vishh mentioned this pull request Sep 27, 2016

Automated cherry pick of #33520 #33590

Closed

luxas mentioned this pull request Sep 30, 2016

Use patched golang1.7.1 for cross-builds targeting darwin #33803

Merged

k8s-github-robot merged commit 86c322e into kubernetes:master Oct 7, 2016

jessfraz added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 7, 2016

jessfraz mentioned this pull request Oct 7, 2016

Automated cherry pick of #33520 #34251 origin release 1.4 #34296

Merged

jessfraz removed the cherrypick-candidate label Oct 7, 2016

dashpole mentioned this pull request Oct 19, 2016

Cadvisor root path configuration #35136

Merged

dashpole added a commit to dashpole/kubernetes that referenced this pull request Oct 22, 2016

Reverted kubernetes#33520, and changed e2e test context to use nodefs

d3ba657

dashpole added a commit to dashpole/kubernetes that referenced this pull request Oct 27, 2016

kubelet calls GetDirFsInfo(root directory) instead of using GetFsInfo…

eb19713

…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs

jessfraz pushed a commit to jessfraz/kubernetes that referenced this pull request Oct 27, 2016

kubelet calls GetDirFsInfo(root directory) instead of using GetFsInfo…

f4eeaad

…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs

jessfraz pushed a commit to jessfraz/kubernetes that referenced this pull request Oct 28, 2016

kubelet calls GetDirFsInfo(root directory) instead of using GetFsInfo…

d9a294d

…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016

kubelet calls GetDirFsInfo(root directory) instead of using GetFsInfo…

2f44e21

…(root label). Reverted kubernetes#33520, and changed e2e test context to use nodefs

Conversation

vishh commented Sep 26, 2016 • edited by k8s-oncall Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vishh commented Sep 26, 2016

Uh oh!

dchen1107 commented Sep 27, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jessfraz commented Oct 5, 2016

Uh oh!

vishh commented Oct 6, 2016

Uh oh!

jessfraz commented Oct 6, 2016

Uh oh!

vishh commented Oct 6, 2016

Uh oh!

vishh commented Oct 6, 2016

Uh oh!

vishh commented Oct 6, 2016

Uh oh!

k8s-ci-robot commented Oct 6, 2016

Uh oh!

jessfraz commented Oct 6, 2016

Uh oh!

k8s-github-robot commented Oct 6, 2016

Uh oh!

k8s-github-robot commented Oct 7, 2016

Uh oh!

jessfraz commented Oct 7, 2016

Uh oh!

jessfraz commented Oct 7, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vishh commented Sep 26, 2016 •

edited by k8s-oncall

Loading

dchen1107 commented Sep 27, 2016 •

edited

Loading