Fixes in HPA: consider only running pods; proper denominator in avg.#33735
Merged
k8s-github-robot merged 1 commit intoSep 29, 2016
Merged
Conversation
…alculations. Fixes in HPA: consider only running pods; proper denominator in avg calculations.
|
Removing label |
Contributor
|
Please include the issues that we hope to fix with this. Also give a credit to the spotter of the len() issue. |
Contributor
|
After that - LGTM. |
Contributor
Author
|
The PR is base on #33529 by @hongshibao, it partially fixes #28692 and #30471. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
Contributor
|
👍 |
|
Automatic merge from submit-queue |
Contributor
|
@jszczepkowski can you open the PR to cherry-pick this into release-1.4 for 1.4.1 |
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 7, 2016
…-#33735-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of #33735: Fixes in HPA ... Fixes in HPA: consider only running pods; proper denominator in avg request calculations. It partially fixes #28692 and #30471 **Release note**: ```release-note Fixes in HPA: consider only running pods; proper denominator in avg request calculations. ```
Contributor
|
was cherry-picked in #34224 |
This was referenced Nov 2, 2016
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…ry-pick-of-#33735-upstream-release-1.4 Automatic merge from submit-queue Automated cherry pick of kubernetes#33735: Fixes in HPA ... Fixes in HPA: consider only running pods; proper denominator in avg request calculations. It partially fixes kubernetes#28692 and kubernetes#30471 **Release note**: ```release-note Fixes in HPA: consider only running pods; proper denominator in avg request calculations. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is