Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Automated cherry pick of #32593#34228

Merged
k8s-github-robot merged 2 commits into
kubernetes:release-1.4from
pigmej:automated-cherry-pick-of-#32593-upstream-release-1.4
Oct 7, 2016
Merged

Automated cherry pick of #32593#34228
k8s-github-robot merged 2 commits into
kubernetes:release-1.4from
pigmej:automated-cherry-pick-of-#32593-upstream-release-1.4

Conversation

@pigmej
Copy link
Copy Markdown
Contributor

@pigmej pigmej commented Oct 6, 2016

Cherry pick of #32593 on release-1.4.
#32593: Subject: [PATCH 1/2] Fix audit_test regex for iso8601 timestamps

Subject: [PATCH 2/2] Fixed edited regex in audit_test unit test


This change is Reviewable

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@pigmej
Copy link
Copy Markdown
Contributor Author

pigmej commented Oct 6, 2016

@johnbieren please confirm that you're ok with that.

@k8s-github-robot k8s-github-robot added this to the v1.4 milestone Oct 6, 2016
@k8s-github-robot k8s-github-robot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 6, 2016
@k8s-github-robot
Copy link
Copy Markdown

The 'parent' PR of a cherry-pick PR must have one of the "release-note" or "release-note-action-required" labels, or this PR must follow the standard/parent release note labeling requirement. (release-note-experimental must be explicit for cherry-picks)

@johnbieren
Copy link
Copy Markdown
Contributor

Yes, I am okay with these commits being contributed

@pigmej
Copy link
Copy Markdown
Contributor Author

pigmej commented Oct 6, 2016

@lavalamp I wonder why cla: no label is applied there, what should we do more about that PR?

@jessfraz jessfraz added lgtm "Looks good to me", indicates that a PR is ready to be merged. cla: human-approved and removed cla: no labels Oct 6, 2016
@jessfraz jessfraz self-assigned this Oct 6, 2016
@lavalamp lavalamp removed their assignment Oct 6, 2016
@k8s-github-robot
Copy link
Copy Markdown

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 7193cf6 into kubernetes:release-1.4 Oct 7, 2016
@k8s-cherrypick-bot
Copy link
Copy Markdown

Commit found in the "release-1.4" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

k8s-github-robot pushed a commit that referenced this pull request Oct 10, 2016
Automatic merge from submit-queue

hack: update cherry-pick script to show subject when patch is split

<!--  Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md and developer guide https://github.com/kubernetes/kubernetes/blob/master/docs/devel/development.md
2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/faster_reviews.md
3. Follow the instructions for writing a release note: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/pull-requests.md#release-notes
-->

**What this PR does / why we need it**:

This is a continuation of #34049, which worked, but then I realized some patch files have more than one subject, see example: #34228

This cleans the output so it looks like this:

```
Automated cherry pick of #32593

Cherry pick of #32593 on release-1.4.

#32593: Fix audit_test regex for iso8601 timestamps
```

pretty!!!

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:
<!--  Steps to write your release note:
1. Use the release-note-* labels to set the release note state (if you have access) 
2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`. 
-->

Signed-off-by: Jess Frazelle <[email protected]>
shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
…-of-#32593-upstream-release-1.4

Automatic merge from submit-queue

Automated cherry pick of kubernetes#32593

Cherry pick of kubernetes#32593 on release-1.4.

kubernetes#32593: Subject: [PATCH 1/2] Fix audit_test regex for iso8601 timestamps
Subject: [PATCH 2/2] Fixed edited regex in audit_test unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants