Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Manual cherry-pick of #35346 #35383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2016
Merged

Manual cherry-pick of #35346 #35383

merged 1 commit into from
Oct 31, 2016

Conversation

bprashanth
Copy link
Contributor

@bprashanth bprashanth commented Oct 22, 2016 •
edited by k8s-oncall
Loading

This change is Reviewable

@bprashanth bprashanth added the release-note-none Denotes a PR that doesn't merit a release note. label Oct 22, 2016
@k8s-github-robot
Copy link

This PR is not for the master branch but does not have the cherrypick-approved label. Adding the do-not-merge label.

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2016
@ixdy
Copy link
Member

ixdy commented Oct 24, 2016

LGTM

@ixdy ixdy added this to the v1.3 milestone Oct 24, 2016
@bprashanth
Copy link
Contributor Author

@k8s-bot gci gce e2e test this

@bprashanth
Copy link
Contributor Author

@k8s-bot kubemark e2e test this

@bprashanth
Copy link
Contributor Author

@k8s-bot gci gke e2e test this

@bprashanth
Copy link
Contributor Author

@k8s-bot cvm gke e2e test this

@ixdy
Copy link
Member

ixdy commented Oct 25, 2016

GKE PR testing on release-1.3 is broken until #35458 merges.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 1a48382. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit 1a48382. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit 1a48382. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@ixdy
Copy link
Member

ixdy commented Oct 25, 2016

@k8s-bot test this

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit 1a48382. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit 1a48382. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@ixdy
Copy link
Member

ixdy commented Oct 26, 2016

@k8s-bot cvm gce e2e test this.

@ixdy ixdy added lgtm "Looks good to me", indicates that a PR is ready to be merged. cherrypick-candidate labels Oct 26, 2016
@ixdy
Copy link
Member

ixdy commented Oct 27, 2016

@bprashanth the PR kubemark tests are broken on 1.3 - probably need to merge manually.

@bprashanth
Copy link
Contributor Author

Thanks for the heads up, @fabioy ok to merge manually?

@fabioy
Copy link
Contributor

fabioy commented Oct 31, 2016

Ah, Kubemark...my little red nemesis.

@bprashanth Change seems safe, merging.

@fabioy fabioy added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Oct 31, 2016
@fabioy fabioy merged commit 39c1aaa into kubernetes:release-1.3 Oct 31, 2016
@k8s-cherrypick-bot
Copy link

Commit found in the "release-1.3" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

shyamjvs pushed a commit to shyamjvs/kubernetes that referenced this pull request Dec 1, 2016
@fabioy
Merge pull request kubernetes#35383 from bprashanth/gcloud_regex_1.3
0e75fed 
Manual cherry-pick of kubernetes#35346
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabioy fabioy

@ixdy ixdy

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
7 participants
@bprashanth @k8s-github-robot @ixdy @k8s-ci-robot @fabioy @k8s-cherrypick-bot @googlebot