Always run the podGC controller.#35476
Merged
Merged
Conversation
Contributor
Author
Contributor
|
LGTM but I would recommend adding a release note to document the change of behavior and why it will always run. Once you have that feel free to self apply. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
foxish
added a commit
to foxish/kubernetes
that referenced
this pull request
Oct 25, 2016
This should be a NOP because we're just moving functionality around and thanks to kubernetes#35476, the podGC controller should always run anyway.
foxish
added a commit
to foxish/kubernetes
that referenced
this pull request
Oct 27, 2016
This should be a NOP because we're just moving functionality around and thanks to kubernetes#35476, the podGC controller should always run anyway.
k8s-github-robot
pushed a commit
that referenced
this pull request
Oct 28, 2016
Automatic merge from submit-queue Moving some force deletion logic from the NC into the PodGC **What this PR does / why we need it**: Moves some pod force-deletion behavior into the PodGC, which is a better place for these. This should be a NOP because we're just moving functionality around and thanks to #35476, the podGC controller should always run. Related: #34160, #35145 cc @gmarek @kubernetes/sig-apps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The podGC controller has evolved to do more than just GC of terminated pods beyond a threshold number. It no longer makes sense to gate running it with the
terminated-pod-gc-thresholdflag. We still ensure that it only runs the terminatedPodsGC if the threshold specified in the argument to the controller manager is > 0.Related discussion: #34160 (comment)
Release note:
This change is