Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use ip link or if{up,down} depending on command availability #35537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 4, 2016
Merged

Use ip link or if{up,down} depending on command availability #35537

merged 1 commit into from
Nov 4, 2016

Conversation

bowei
Copy link
Member

@bowei bowei commented Oct 25, 2016 •
edited by ixdy
Loading

Use ip link or if{up,down} depending on command availability

This is a backport of 4fde09d. The GCI
image does not have the if[up,down} command.

Fixes #33302

This change is Reviewable

@freehan @bowei
Use ip link or if{up,down} depending on command availability
aad550e 
This is a backport of 4fde09d. The GCI
image does not have the if[up,down} command.

Fixes kubernetes#33302
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Oct 25, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GCE etcd3 e2e failed for commit aad550e. Full PR test history.

The magic incantation to run this job again is @k8s-bot gce etcd3 e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@bowei
Copy link
Member Author

bowei commented Oct 25, 2016

@k8s-bot cvm gke e2e test this
@k8s-bot gci gke e2e test this
@k8s-bot kubemark e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GKE smoke e2e failed for commit aad550e. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit aad550e. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@fejta
Copy link
Contributor

fejta commented Oct 25, 2016

@ixdy these failures look related to the get-kube changes?

@fejta fejta assigned ixdy and unassigned fejta Oct 25, 2016
@ixdy
Copy link
Member

ixdy commented Oct 25, 2016

@fejta yeah I'm still waiting on #35458 to get merged. @fabioy

@bowei
Copy link
Member Author

bowei commented Oct 25, 2016

@fabioy : hey, looks like there are some issues with the test infra for 1.3? It'd would be great if you could take look...

@ixdy
Copy link
Member

ixdy commented Oct 25, 2016

@k8s-bot test this

@k8s-ci-robot
Copy link
Contributor

Jenkins Kubemark GCE e2e failed for commit aad550e. Full PR test history.

The magic incantation to run this job again is @k8s-bot kubemark e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCI GCE e2e failed for commit aad550e. Full PR test history.

The magic incantation to run this job again is @k8s-bot gci gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@ixdy ixdy assigned fabioy and unassigned ixdy Oct 26, 2016
@bowei
Copy link
Member Author

bowei commented Oct 27, 2016

@fabioy : any progress on this?

@fabioy
Copy link
Contributor

fabioy commented Oct 31, 2016

@k8s-bot gci gce e2e test this

@fabioy fabioy added cherrypick-candidate cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. release-note-none Denotes a PR that doesn't merit a release note. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 31, 2016
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@fabioy fabioy added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Oct 31, 2016
@bowei
Copy link
Member Author

bowei commented Nov 1, 2016

@fabioy @timstclair is the kubemark test broken? seems to be stuck on this...

@timstclair
Copy link

@k8s-bot kubemark e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 2f65865 into kubernetes:release-1.3 Nov 4, 2016
@bowei bowei deleted the issue-33302 branch February 21, 2017 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fabioy fabioy

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.