WIP:kubelet: support multi-headers when getting pod from HTTP source #38089

chentao1596 · 2016-12-05T07:27:35Z

What this PR does / why we need it:
Only support one header parameter when getting pod from HTTP source, it's not work very well when server need multi header parameters.
1，Add one run parameter for kubelet: "manifest-url-headers" - to be used to supporting more than one HTTP header
2，Commit some auto-generated codes

Release note:

kubelet: `--manifest-url-header` can now be specified multiple times, to set multiple custom headers when getting pods from an HTTP source

k8s-ci-robot · 2016-12-05T07:27:39Z

Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

k8s-reviewable · 2016-12-05T07:27:46Z

This change is

liggitt · 2016-12-05T13:27:39Z

cmd/kubelet/app/options/options.go

@@ -98,6 +98,8 @@ func (s *KubeletServer) AddFlags(fs *pflag.FlagSet) {
 	fs.DurationVar(&s.HTTPCheckFrequency.Duration, "http-check-frequency", s.HTTPCheckFrequency.Duration, "Duration between checking http for new data")
 	fs.StringVar(&s.ManifestURL, "manifest-url", s.ManifestURL, "URL for accessing the container manifest")
 	fs.StringVar(&s.ManifestURLHeader, "manifest-url-header", s.ManifestURLHeader, "HTTP header to use when accessing the manifest URL, with the key separated from the value with a ':', as in 'key:value'")
+	fs.MarkDeprecated("manifest-url-header", "Use --manifest-url-headers instead. Will be removed in a future version.")


Use string array var and specify multiple times. We don't want to use stringslicevar with data that could contain commas

Actually, you can make the existing arg a string array var, repeat it if needed and avoid depreciation altogether

vishh · 2016-12-05T13:33:50Z

Why is this change necessary?

k8s-ci-robot · 2016-12-06T06:24:05Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.

If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

chentao1596 · 2016-12-06T06:49:04Z

@liggitt I changed the type of "--manifest-url-header" to "stringArray", i think you are right: using exist param is better, rather than adding the other one. PTAL, thx!

chentao1596 · 2016-12-06T06:49:45Z

@vishh hi, my HTTP server need multi headers when getting pods from it, but kubelet just support one until now. In this case, i must change implemention of HTTP server to get used to it, it's not very convenient, so i think it's better if support multi headers, thx!

yujuhong · 2016-12-06T18:46:26Z

Please remove the k8s release note that's not relevant to this PR in #38089 (comment)

timstclair · 2016-12-06T20:49:40Z

pkg/apis/componentconfig/v1alpha1/zz_generated.conversion.go

@@ -254,7 +254,7 @@ func autoConvert_v1alpha1_KubeletConfiguration_To_componentconfig_KubeletConfigu
 	out.FileCheckFrequency = in.FileCheckFrequency
 	out.HTTPCheckFrequency = in.HTTPCheckFrequency
 	out.ManifestURL = in.ManifestURL
-	out.ManifestURLHeader = in.ManifestURLHeader
+	out.ManifestURLHeader = *(*[]string)(unsafe.Pointer(&in.ManifestURLHeader))


why is this cast necessary?

timstclair · 2016-12-06T20:50:28Z

pkg/apis/componentconfig/v1alpha1/zz_generated.deepcopy.go

@@ -169,7 +169,13 @@ func DeepCopy_v1alpha1_KubeletConfiguration(in interface{}, out interface{}, c *
 		out.FileCheckFrequency = in.FileCheckFrequency
 		out.HTTPCheckFrequency = in.HTTPCheckFrequency
 		out.ManifestURL = in.ManifestURL
-		out.ManifestURLHeader = in.ManifestURLHeader
+		if in.ManifestURLHeader != nil {
+			in, out := &in.ManifestURLHeader, &out.ManifestURLHeader


don't need to use pointers here

chentao1596 · 2016-12-07T04:23:28Z

@timstclair This code was generated by the script "hack/update-codecgen.sh", i should not to edit them, whether my understanding is right？thank you!

chentao1596 · 2016-12-07T04:24:26Z

@yujuhong I removed it, thank you!

k8s-ci-robot · 2017-09-21T10:16:09Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

chentao1596 · 2017-09-25T06:40:49Z

@liggitt
I am sorry for this delay.
Files has been generated, and my code has been rebased to the latest version, thank you!

liggitt · 2017-09-25T13:23:33Z

/ok-to-test

LGTM, cc @kubernetes/sig-node-api-reviews @mtaufen for kubelet config change

k8s-ci-robot · 2017-09-28T04:08:43Z

@chentao1596: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
Jenkins CRI GCE Node e2e	a8e883cace7c08342db820a8d75e9fc4dd828158	link	`@k8s-bot cri node e2e test this`
Jenkins GKE smoke e2e	8155ab4bd3aee719eef0d9d437a3f8c9e451fd75	link	`@k8s-bot cvm gke e2e test this`
Jenkins GCI GKE smoke e2e	8155ab4bd3aee719eef0d9d437a3f8c9e451fd75	link	`@k8s-bot gci gke e2e test this`
pull-kubernetes-unit	`9ad425b`	link	`/test pull-kubernetes-unit`
pull-kubernetes-e2e-gce-bazel	`9ad425b`	link	`/test pull-kubernetes-e2e-gce-bazel`
pull-kubernetes-bazel-test	`9ad425b`	link	`/test pull-kubernetes-bazel-test`
pull-kubernetes-e2e-gce-etcd3	`9ad425b`	link	`/test pull-kubernetes-e2e-gce-etcd3`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-github-robot · 2017-11-03T08:07:40Z

@chentao1596 PR needs rebase

k8s-github-robot · 2017-11-27T08:07:19Z

This PR hasn't been active in 60 days. It will be closed in 29 days (Dec 27, 2017).

cc @chentao1596 @dchen1107 @liggitt @vishh

You can add 'keep-open' label to prevent this from happening, or add a comment to keep it open another 90 days

fejta-bot · 2018-02-25T08:26:49Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

mtaufen · 2018-02-26T19:16:19Z

closing this, as equivalent work was completed in #54643 and #55254

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2016

chentao1596 mentioned this pull request Dec 5, 2016

Kubelet get pod from HTTP source #37539

Closed

k8s-github-robot assigned vishh Dec 5, 2016

k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Dec 5, 2016

chentao1596 changed the title ~~add --manifest-url-headers~~ kubelet: support multi-headers when getting pod from HTTP source Dec 5, 2016

chentao1596 force-pushed the support-multi-manifest-url-headers branch from 5b0d858 to 31b8ba9 Compare December 5, 2016 08:05

liggitt requested changes Dec 5, 2016

View reviewed changes

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 6, 2016

chentao1596 force-pushed the support-multi-manifest-url-headers branch from 2967273 to 7778777 Compare December 6, 2016 06:24

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 6, 2016

timstclair reviewed Dec 6, 2016

View reviewed changes

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 7, 2016

chentao1596 force-pushed the support-multi-manifest-url-headers branch from 7778777 to 658a3ac Compare December 7, 2016 03:50

k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 7, 2016

chentao1596 force-pushed the support-multi-manifest-url-headers branch from 9495484 to a7fd07e Compare December 7, 2016 04:21

k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 21, 2017

k8s-github-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Sep 21, 2017

k8s-ci-robot removed the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 21, 2017

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Sep 21, 2017

chentao1596 force-pushed the support-multi-manifest-url-headers branch from f453b5a to 4623204 Compare September 21, 2017 10:21

chentao1596 force-pushed the support-multi-manifest-url-headers branch from bdc3aaa to d268f5a Compare September 21, 2017 10:24

k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Sep 25, 2017

chentao11596 added 2 commits September 28, 2017 10:48

support multi-headers when getting pod from HTTP source

2095b71

auto-generated codes when modify the kubelet's options ManifestURLHeader

9ad425b

chentao1596 force-pushed the support-multi-manifest-url-headers branch from 2677190 to 9ad425b Compare September 28, 2017 03:08

chentao1596 changed the title ~~kubelet: support multi-headers when getting pod from HTTP source~~ WIP:kubelet: support multi-headers when getting pod from HTTP source Oct 14, 2017

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2017

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 3, 2017

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 25, 2018

mtaufen closed this Feb 26, 2018

chentao1596 deleted the support-multi-manifest-url-headers branch March 13, 2018 08:48

WIP:kubelet: support multi-headers when getting pod from HTTP source #38089

WIP:kubelet: support multi-headers when getting pod from HTTP source #38089

Uh oh!

Conversation

chentao1596 commented Dec 5, 2016 • edited by liggitt Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Dec 5, 2016

Uh oh!

k8s-reviewable commented Dec 5, 2016

Uh oh!

liggitt Dec 5, 2016

Choose a reason for hiding this comment

Uh oh!

liggitt Dec 5, 2016

Choose a reason for hiding this comment

Uh oh!

vishh commented Dec 5, 2016

Uh oh!

k8s-ci-robot commented Dec 6, 2016

Uh oh!

chentao1596 commented Dec 6, 2016

Uh oh!

chentao1596 commented Dec 6, 2016

Uh oh!

yujuhong commented Dec 6, 2016

Uh oh!

timstclair Dec 6, 2016

Choose a reason for hiding this comment

Uh oh!

timstclair Dec 6, 2016

Choose a reason for hiding this comment

Uh oh!

chentao1596 commented Dec 7, 2016

Uh oh!

chentao1596 commented Dec 7, 2016

Uh oh!

k8s-ci-robot commented Sep 21, 2017

Uh oh!

chentao1596 commented Sep 25, 2017

Uh oh!

liggitt commented Sep 25, 2017

Uh oh!

k8s-ci-robot commented Sep 28, 2017

Uh oh!

k8s-github-robot commented Nov 3, 2017

Uh oh!

k8s-github-robot commented Nov 27, 2017

Uh oh!

fejta-bot commented Feb 25, 2018

Uh oh!

mtaufen commented Feb 26, 2018

Uh oh!

Uh oh!

chentao1596 commented Dec 5, 2016 •

edited by liggitt

Loading