Thanks to visit codestin.com
Credit goes to github.com

Skip to content

make local-up-cluster.sh match "normal" launch without anonymous access#38898

Merged
k8s-github-robot merged 1 commit into
kubernetes:release-1.5from
deads2k:fix-local-up-cluster
Dec 19, 2016
Merged

make local-up-cluster.sh match "normal" launch without anonymous access#38898
k8s-github-robot merged 1 commit into
kubernetes:release-1.5from
deads2k:fix-local-up-cluster

Conversation

@deads2k
Copy link
Copy Markdown
Contributor

@deads2k deads2k commented Dec 16, 2016 •
edited
Loading

Ref #38847

This changes the readiness detection, but keeps the defaults matching the "normal" launch without anonymous auth.

Fixes an issue where `hack/local-up-cluster.sh` would fail on the API server start with

!!! [1215 15:42:56] Timed out waiting for apiserver:  to answer at https://localhost:6443/version; tried 10 waiting 1 between each

@janetkuo @saad-ali

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2016
@k8s-reviewable
Copy link
Copy Markdown

k8s-reviewable commented Dec 16, 2016

This change is Reviewable

@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Dec 16, 2016
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Dec 16, 2016

Jenkins GKE smoke e2e failed for commit 757e376. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@saad-ali saad-ali added this to the v1.5 milestone Dec 16, 2016
@saad-ali saad-ali added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Dec 16, 2016
@saad-ali saad-ali self-assigned this Dec 16, 2016
@saad-ali
Copy link
Copy Markdown
Member

saad-ali commented Dec 16, 2016

Please update the original comment to add a release note indicating this fixes a break in local-up-cluster.sh #38847.

Release note format:


```release-note
blah blah blah
`` `

@saad-ali
Copy link
Copy Markdown
Member

saad-ali commented Dec 16, 2016

Also can you verify that ./hack/local-up-cluster.sh starts without issue with this change?

@saad-ali
Copy link
Copy Markdown
Member

saad-ali commented Dec 16, 2016

@k8s-bot cvm gke e2e test this

@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Dec 16, 2016
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Dec 16, 2016
@saad-ali
Copy link
Copy Markdown
Member

saad-ali commented Dec 16, 2016

Make sure to cherry pick this, #38708, and #38717 back to the master branch.

@saad-ali saad-ali mentioned this pull request Dec 16, 2016
Merged
@spxtr spxtr removed their assignment Dec 16, 2016
@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Dec 19, 2016

Also can you verify that ./hack/local-up-cluster.sh starts without issue with this change?

Started fine for me.

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Dec 19, 2016

Make sure to cherry pick this, #38708, and #38717 back to the master branch.

The audit trail one already merged. I think we'd like to try a different approach for anonymous auth in master that involves tweaking evaluation rules for ABAC and RBAC instead.

@deads2k
Copy link
Copy Markdown
Contributor Author

deads2k commented Dec 19, 2016

Please update the original comment to add a release note indicating this fixes a break in local-up-cluster.sh #38847.

done.

@saad-ali saad-ali added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2016
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Dec 19, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Dec 19, 2016

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 400dbac into kubernetes:release-1.5 Dec 19, 2016
@lavalamp
Copy link
Copy Markdown
Contributor

lavalamp commented Jan 26, 2017

I think this fix cured the symptom--the script completes--but did not actually cure the problem. The apiserver produced rejects all connections from controller manager.

@deads2k deads2k deleted the fix-local-up-cluster branch February 1, 2017 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@saad-ali saad-ali

Labels

cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.5

Development

Successfully merging this pull request may close these issues.

7 participants

@deads2k @k8s-reviewable @k8s-ci-robot @saad-ali @k8s-github-robot @lavalamp @spxtr