Thanks to visit codestin.com
Credit goes to github.com

Skip to content

AWS: Remove duplicate calls to DescribeInstance during volume operations#39842

Merged
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
gnufied:fix-aws-2x-calls
Jan 18, 2017
Merged

AWS: Remove duplicate calls to DescribeInstance during volume operations#39842
k8s-github-robot merged 1 commit into
kubernetes:masterfrom
gnufied:fix-aws-2x-calls

Conversation

@gnufied
Copy link
Copy Markdown
Member

@gnufied gnufied commented Jan 13, 2017

This change removes all duplicate calls to describeInstance
from aws volume code path.

What this PR does / why we need it:

This PR removes the duplicate calls present in disk check code paths in AWS. I can confirm that getAWSInstance actually returns all instance information already and hence there is no need of making separate describeInstance call.

Related to - #39526

cc @justinsb @jsafrane

@gnufied
Remove duplicate calls to describeInstance from aws
aaa56e2 
This change removes all duplicate calls to describeInstance
from aws volume code path.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 13, 2017
@k8s-reviewable
Copy link
Copy Markdown

k8s-reviewable commented Jan 13, 2017

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Jan 13, 2017
@justinsb justinsb changed the title Remove duplicate calls to describeInstance from aws AWS: Remove duplicate calls to DescribeInstance during volume operations Jan 18, 2017
@justinsb justinsb added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Jan 18, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Jan 18, 2017

Automatic merge from submit-queue (batch tested with PRs 39625, 39842)

@k8s-github-robot k8s-github-robot merged commit e1fa151 into kubernetes:master Jan 18, 2017
@gnufied gnufied mentioned this pull request Jan 30, 2017
Merged
@saad-ali saad-ali added this to the v1.5 milestone Jan 30, 2017
@saad-ali saad-ali added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate labels Jan 30, 2017
k8s-github-robot pushed a commit that referenced this pull request Jan 31, 2017
Merge pull request #40685 from gnufied/automated-cherry-pick-of-#3984…
d77b7f6 
…2-upstream-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #39842

Cherry pick of #39842 on release-1.5.

#39842: Remove duplicate calls to describeInstance from aws
@k8s-cherrypick-bot
Copy link
Copy Markdown

k8s-cherrypick-bot commented Jan 31, 2017

Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@justinsb justinsb

Labels

cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.5

Development

Successfully merging this pull request may close these issues.

7 participants

@gnufied @k8s-reviewable @k8s-github-robot @k8s-cherrypick-bot @justinsb @saad-ali @k8s-ci-robot