Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update repo local config to allow redirects from gopkg.in #40875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2017
Merged

update repo local config to allow redirects from gopkg.in #40875

merged 1 commit into from
Feb 3, 2017

Conversation

mikedanese
Copy link
Member

@mikedanese mikedanese commented Feb 2, 2017 •
edited
Loading

closes #39583

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 2, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@spxtr
Copy link
Contributor

spxtr commented Feb 2, 2017

I thought this needed to be global, since the actual git repo it checks out will be under $GOPATH/src/bla.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Feb 2, 2017
@mikedanese mikedanese added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Feb 2, 2017
@mikedanese mikedanese mentioned this pull request Feb 2, 2017
Closed
@ixdy
Copy link
Contributor

ixdy commented Feb 2, 2017

I'm a little wary about updating git configs automatically, but I'm not sure if there's a better way...

@mikedanese
Copy link
Member Author

@ixdy, cluster local gitconfigs are less bad then global. We seem to not be getting any traction over at gopkg.in and this continues to break people.

@spxtr
Copy link
Contributor

spxtr commented Feb 2, 2017

As long as this actually works,

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2017
@spxtr
Copy link
Contributor

spxtr commented Feb 2, 2017 •
edited
Loading

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: mikedanese, spxtr

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 40884, 40809, 40845, 40866, 40875)

@k8s-github-robot k8s-github-robot merged commit 52d31b9 into kubernetes:master Feb 3, 2017
@mikedanese mikedanese deleted the bzl-verify-fix branch February 3, 2017 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@spxtr spxtr

@ixdy ixdy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hack/verify-bazel.sh failing with HTTP error 301
6 participants
@mikedanese @k8s-reviewable @spxtr @ixdy @k8s-github-robot @k8s-ci-robot