Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Don't fail if the grep fails to match any resources #43185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2017
Merged

Don't fail if the grep fails to match any resources #43185

merged 1 commit into from
Mar 16, 2017

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Mar 16, 2017

Ref #42208 #41917

/assign @jessfraz @ixdy
/release-note-none

We have a variety of upgrade jobs that intentionally run test code from 1.3, so merge this back into there as well

https://k8s-testgrid.appspot.com/release-1.5-all#Summary
https://k8s-testgrid.appspot.com/release-1.5-all#gke-1.3-1.5-upgrade-master

Source of this failure group: https://storage.googleapis.com/k8s-gubernator/triage/index.html#69095700b0b2b3dc3c46

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2017
@k8s-github-robot k8s-github-robot added do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Mar 16, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@fejta
Copy link
Contributor Author

fejta commented Mar 16, 2017

/assign @fabioy @timstclair

@fejta
Copy link
Contributor Author

fejta commented Mar 16, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Mar 16, 2017
@fejta fejta removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 16, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Mar 16, 2017
@fejta
Copy link
Contributor Author

fejta commented Mar 16, 2017

FYI this doesn't need a real release cut but I'd like to merge this so we create a new CI build that has these fixes so we stop producing these errors in our 1.4 and 1.5 upgrade tests

@ixdy
Copy link
Member

ixdy commented Mar 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fejta, ixdy
We suggest the following additional approver: @vishh

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@fabioy fabioy added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cherrypick-candidate and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels Mar 16, 2017
@fabioy
Copy link
Contributor

fabioy commented Mar 16, 2017

Approved.

@fabioy fabioy merged commit 587d164 into kubernetes:release-1.3 Mar 16, 2017
@fejta fejta deleted the fix branch March 16, 2017 17:24
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timstclair timstclair

@fabioy fabioy

@ixdy ixdy

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@fejta @k8s-reviewable @ixdy @k8s-github-robot @fabioy @k8s-cherrypick-bot @jessfraz @timstclair @k8s-ci-robot