Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump runc to d223e2a #44940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2017
Merged

Bump runc to d223e2a #44940

merged 1 commit into from
Apr 27, 2017

Conversation

sjenning
Copy link
Contributor

@sjenning sjenning commented Apr 26, 2017 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Apr 26, 2017
@derekwaynecarr derekwaynecarr added cherrypick-candidate release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 26, 2017
@derekwaynecarr derekwaynecarr self-assigned this Apr 26, 2017
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@derekwaynecarr derekwaynecarr added this to the v1.6.1 milestone Apr 26, 2017
@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@derekwaynecarr
Copy link
Member

@sjenning -- is it worth evaluating taking an older level of runc closer to level that merged opencontainers/runc#1124 ? Do you know if the code at that time had the awkward -1 convention?

@sjenning
Copy link
Contributor Author

@derekwaynecarr what is the minimal version that contains your fix?

@derekwaynecarr
Copy link
Member

we would need to take the git commit d223e2adae83f62d58448a799a5da05730228089

@sjenning
Copy link
Contributor Author

yeah, the first tagged release in which that commit is included is v1.0.0-rc3. i.e. v1.0.0-rc2 would have it. unless we want to go off the reservation and do a untagged dep by commit rather than version.

@derekwaynecarr
Copy link
Member

didn't we have an untagged commit previously?

@sjenning sjenning changed the title Bump runc to v1.0.0-rc3 Bump runc to d223e2a Apr 26, 2017
@k8s-github-robot k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 26, 2017
@derekwaynecarr
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2017
@derekwaynecarr
Copy link
Member

@dchen1107 @smarterclayton -- can either of you approve this? its the smallest bump we can make. the changes in runc are localized to selinux updates that appear reasonable, a bunch of comment changes, and the fix for systemd cgroup apply semantics to ignore already exists errors.

@k8s-cherrypick-bot
Copy link

Removing label cherrypick-candidate because no release milestone was set. This is an invalid state and thus this PR is not being considered for cherry-pick to any release branch. Please add an appropriate release milestone and then re-add the label.

@smarterclayton
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, sjenning, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit a92007b into kubernetes:master Apr 27, 2017
@sjenning sjenning mentioned this pull request Jun 27, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Jun 27, 2017
Merge pull request #48117 from sjenning/bump-runc-1.6
5b679f4 
Automatic merge from submit-queue

bump runc to d223e2a

cherry-pick #44940

by user request #43856 (comment)

@derekwaynecarr @djsly @vishh 

```release-note
Bump runc to v1.0.0-rc2-49-gd223e2a - fixes `failed to initialise top level QOS containers` kubelet error.
```
@sjenning sjenning mentioned this pull request Jun 30, 2017
Merged
@sjenning sjenning deleted the bump-runc branch August 16, 2017 02:17
@opsnull opsnull mentioned this pull request Jun 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

@derekwaynecarr derekwaynecarr

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sjenning @k8s-reviewable @k8s-cherrypick-bot @derekwaynecarr @smarterclayton @k8s-github-robot @dchen1107 @k8s-ci-robot