Thanks to visit codestin.com
Credit goes to github.com

Skip to content

use default namespace to do rollingupdate #4696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 23, 2015
Merged

use default namespace to do rollingupdate #4696

merged 1 commit into from
Feb 23, 2015

Conversation

kazegusuri
Copy link
Contributor

rollingupdate command uses namespace specified from resource file (such as redis.json) instead of current namespace, so the command fails except the default namespace.

$ kubectl --namespace=test create -f examples/guestbook-go/redis-master-controller.json
redis-master-controller

# modifiy examples/guestbook-go/redis-master-controller.json

$ kubectl --namespace=test rollingupdate redis-master-controller -f redis-master-controller.json
F0221 20:50:44.122863   17881 rollingupdate.go:99] replicationController "redis-master-controller" not found

$ kubectl --namespace=test get rc
CONTROLLER                CONTAINER(S)        IMAGE(S)            SELECTOR                 REPLICAS
redis-master-controller   redis-master        gurpartap/redis     name=redis,role=master   1

@zmerlynn zmerlynn added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2015
@zmerlynn
Copy link
Member

LGTM

rjnagal added a commit that referenced this pull request Feb 23, 2015
@rjnagal
Merge pull request #4696 from kazegusuri/rollingupdate-namespace-aware
33855c2 
use default namespace to do rollingupdate
@rjnagal rjnagal merged commit 33855c2 into kubernetes:master Feb 23, 2015
@kazegusuri kazegusuri deleted the rollingupdate-namespace-aware branch May 23, 2015 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kazegusuri @zmerlynn @googlebot @rjnagal