Add a new API version apps/v1beta2 #48746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38f2b3c to
a926fde
Compare
|
@kubernetes/sig-apps-api-reviews This is ready for review. |
0xmichalis
reviewed
Jul 12, 2017
pkg/apis/apps/v1beta2/conversion.go
Outdated
|
/approve |
|
/assign @smarterclayton |
|
/approve |
|
/retest |
|
/test pull-kubernetes-e2e-gce-etcd3 Seems like a test infra problem: #49320 |
Apps clientset refers to AppsV1beta2 after apps/v1beta2 is created. Use AppsV1beta1 for now before switching everything to AppsV1beta2.
|
/test pull-kubernetes-e2e-gce-etcd3 |
|
Finally, all green again 😄 |
kow3ns
approved these changes
Jul 21, 2017
| appsv1beta1.SchemeGroupVersion, | ||
| appsv1beta2.SchemeGroupVersion, | ||
| // TODO: enable apps/v1beta2 by default before 1.8 release, after the API changes are done | ||
| // appsv1beta2.SchemeGroupVersion, |
| StatefulSetRevisionLabel = ControllerRevisionHashLabelKey | ||
| ) | ||
|
|
||
| // WIP: This is not ready to be used and we plan to make breaking changes to it. |
There was a problem hiding this comment.
Everything looks marked as WIP. +1
11 tasks
|
Thanks much. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bgrant0607, erictune, janetkuo, kow3ns Associated issue: 49135 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
The |
|
Automatic merge from submit-queue |
2 tasks
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 9, 2017
Automatic merge from submit-queue Deprecate Deployment .spec.rollbackTo field ~Depends on #48746~ (merged) xref: #46934, #49135 1. Deprecate Deployment field `.spec.rollbackTo` in `extensions/v1beta1` and `apps/v1beta1`, and remove the same field and `/rollback` endpoint from `apps/v1beta2` Deployment. 1. Add an annotation `deprecated.deployment.rollback.to` in `apps/v1beta2` for conversion to/from other versions. Note: `apps/v1beta2` is new in 1.8 (and WIP), so it is okay to make breaking changes to it. ```release-note Deprecate Deployment .spec.rollbackTo field ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: #49135
This PR adds a new API version
apps/v1beta2which contains a copy (of types, conversions, and defaults) ofapps/v1beta1StatefulSet, Deployment, and their subresources. Note thatapps/v1beta2is still WIP and we will make breaking changes to it before releasing 1.8.Moving core controllers (StatefulSet, Deployment, ReplicaSet, DaemonSet) to
apps/v1beta2is the first step of moving them toapps/v1(GA).This PR is a starting point for DaemonSet and ReplicaSet to move from
/extensionsto/appsand for Deployment and StatefulSet to make some breaking changes (e.g. new defaults and/or remove deprecated fields).