Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix race in proxy unit test #49404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2017
Merged

fix race in proxy unit test #49404

merged 1 commit into from
Jul 21, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 21, 2017 •
edited
Loading

fixes #49413, follow up to #49353 to fix a race in the unit test:

go test -v k8s.io/kubernetes/vendor/k8s.io/kube-aggregator/pkg/apiserver -run TestProxyUpgrade$
handler_proxy_test.go:328: invalid hostname + insecure: expected called=true, got false
testing.go:610: race detected during execution of test

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/48746/pull-kubernetes-unit/42230/

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2017
@liggitt
Copy link
Member Author

liggitt commented Jul 21, 2017

cc @ncdc @janetkuo

@liggitt liggitt assigned ncdc and unassigned lavalamp and cheftako Jul 21, 2017
@liggitt liggitt added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Jul 21, 2017
@liggitt liggitt mentioned this pull request Jul 21, 2017
Merged
@ncdc
Copy link
Member

ncdc commented Jul 21, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2017
@deads2k
Copy link
Contributor

deads2k commented Jul 21, 2017

/approve no-issue

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt, ncdc

Associated issue requirement bypassed by: deads2k

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2017
@janetkuo
Copy link
Member

Thanks for the quick fix!

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 3bae345 into kubernetes:master Jul 21, 2017
@liggitt liggitt deleted the test-race branch August 1, 2017 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ncdc ncdc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

handler_proxy_test.go:328: invalid hostname + insecure: expected called=true, got false
8 participants
@liggitt @ncdc @deads2k @k8s-github-robot @janetkuo @lavalamp @cheftako @k8s-ci-robot