Cleanup DaemonSet templateGeneration #49454

dixudx · 2017-07-23T10:24:08Z

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #49336

Special notes for your reviewer:

/cc @janetkuo @foxish

~~Depends on #49071~~ (Merged)

Release note:

None

k8s-ci-robot · 2017-07-23T10:24:15Z

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

janetkuo · 2017-07-25T18:28:58Z

pkg/apis/apps/v1beta2/conversion.go

No need to delete this annotation

Just took a closer look, you touched out.Annotations here, which is correct. Please ignore the previous comment.

@janetkuo Will rebase and update the PR once #49071 gets merged. Seems #49071 has been approved.

janetkuo · 2017-07-25T18:31:27Z

pkg/apis/apps/v1beta2/conversion.go

They're pointers, need to be converted with the way you did in L393

janetkuo · 2017-07-25T18:33:54Z

pkg/apis/apps/v1beta2/conversion.go

Would you move these closer to other DaemonSet conversion codes? The TODO comment does not apply to these conversion codes.

janetkuo · 2017-07-25T18:40:11Z

Thanks a lot for the fix! You'd need to run auto-gen scripts again (make update will run all auto-gen scripts). Please put those auto-generated codes in a separate commit in this PR so that rebase would much be easier.

janetkuo · 2017-07-25T18:41:31Z

@k8s-bot ok to test

janetkuo · 2017-07-25T21:37:06Z

pkg/apis/apps/v1beta2/conversion.go

Need to check if Annotations is nil or not, otherwise this will panic

if out.Annotations == nil { out.Annotations = make(map[string]string) }

janetkuo · 2017-07-26T02:18:33Z

@dixudx would you update conversion_test.go as well?

dixudx · 2017-07-26T02:19:39Z

@janetkuo Yeah, count on me.

dixudx · 2017-07-26T02:22:55Z

@janetkuo Add conversion_test.go in this PR or open a new PR ?

bgrant0607 · 2017-08-10T17:01:06Z

I don't think a user will understand the change just by reading the release note.

kubernetes/community#484

dixudx · 2017-08-11T01:01:17Z

@bgrant0607 Updated the release note. PTAL.

janetkuo · 2017-08-11T15:28:45Z

I don't recall what release note you wrote originally, but I think something like "Deprecate .spec.templateGeneration field of extensions/v1beta1 DaemonSet" is enough

bgrant0607 · 2017-08-11T22:24:48Z

@janetkuo The original note was something like "Cleanup templateGeneration", which was vague. Your suggestion is fine.

…nSet to apps/v1beta2

dixudx · 2017-08-12T02:44:04Z

@janetkuo Rebased. PTAL. Thanks.

janetkuo · 2017-08-12T05:59:18Z

/lgtm

janetkuo · 2017-08-12T06:03:24Z

Just took a closer look, template generation was already deprecated in 1.7. This PR just removes the use of it in apps/v1beta2 DaemonSet. Since apps/v1beta2 was added in this release (1.8), this PR does not need a release note.

dixudx · 2017-08-12T07:39:25Z

/assign @thockin
Need your approval. Thanks.

janetkuo · 2017-08-14T07:32:02Z

@bgrant0607 would you take another look?

thockin · 2017-08-14T20:04:16Z

Was v1beta2 available in 1.7 releases?

https://kubernetes.io/docs/reference/deprecation-policy/

dixudx · 2017-08-15T02:40:42Z

@thockin apps/v1beta2 is for 1.8 release.

thockin · 2017-08-15T06:01:22Z

/approve

k8s-github-robot · 2017-08-15T06:01:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, janetkuo, thockin

Associated issue: 49336

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~api/OWNERS~~ [thockin]
~~docs/OWNERS~~ [thockin]
~~pkg/apis/OWNERS~~ [thockin]
~~staging/src/k8s.io/api/OWNERS~~ [thockin]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-08-15T06:14:25Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2017-08-15T07:01:06Z

Automatic merge from submit-queue

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 23, 2017

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 23, 2017

k8s-github-robot assigned smarterclayton and deads2k Jul 23, 2017

dixudx mentioned this pull request Jul 23, 2017

Clean up deprecated DaemonSet templateGeneration field #49336

Closed

dixudx force-pushed the cleanup_DaemonSet_templateGeneration branch from e2055d4 to 7e7868b Compare July 24, 2017 02:04

dixudx mentioned this pull request Jul 24, 2017

Add v1beta2.DaemonSet #49071

Merged

dixudx force-pushed the cleanup_DaemonSet_templateGeneration branch from 7e7868b to 7140223 Compare July 25, 2017 02:35

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2017

janetkuo assigned foxish and janetkuo and unassigned smarterclayton and deads2k Jul 25, 2017

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2017

janetkuo reviewed Jul 25, 2017

View reviewed changes

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 25, 2017

janetkuo assigned caesarxuchao Jul 25, 2017

janetkuo reviewed Jul 25, 2017

View reviewed changes

kow3ns mentioned this pull request Jul 26, 2017

Move workload API objects to group version apps/v1beta2 #49135

Closed

11 tasks

dixudx force-pushed the cleanup_DaemonSet_templateGeneration branch from 7140223 to e178946 Compare July 26, 2017 05:08

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2017

dixudx added 2 commits August 12, 2017 02:15

deprecation of .spec.templateGeneration from extensions/v1beta1 Daemo…

34d573c

…nSet to apps/v1beta2

auto-gen

4d3cba7

dixudx force-pushed the cleanup_DaemonSet_templateGeneration branch from f9e7189 to 4d3cba7 Compare August 12, 2017 02:42

k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 12, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2017

k8s-ci-robot assigned thockin Aug 12, 2017

janetkuo added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 14, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2017

k8s-github-robot merged commit 3537f8f into kubernetes:master Aug 15, 2017

dixudx deleted the cleanup_DaemonSet_templateGeneration branch August 15, 2017 07:03

douglas mentioned this pull request Nov 14, 2019

Review usage of deprecated field in DaemonSet parent_of_pod? method Shopify/krane#627

Open

douglas mentioned this pull request Jan 20, 2020

Use metadata.generation instead of deprecated attributes Shopify/krane#671

Closed

Cleanup DaemonSet templateGeneration #49454

Cleanup DaemonSet templateGeneration #49454

Uh oh!

Conversation

dixudx commented Jul 23, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Jul 23, 2017

Uh oh!

janetkuo Jul 25, 2017

Choose a reason for hiding this comment

Uh oh!

janetkuo Jul 26, 2017

Choose a reason for hiding this comment

Uh oh!

dixudx Jul 26, 2017

Choose a reason for hiding this comment

Uh oh!

janetkuo Jul 25, 2017

Choose a reason for hiding this comment

Uh oh!

janetkuo Jul 25, 2017

Choose a reason for hiding this comment

Uh oh!

janetkuo commented Jul 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

janetkuo commented Jul 25, 2017

Uh oh!

janetkuo Jul 25, 2017

Choose a reason for hiding this comment

Uh oh!

janetkuo Jul 25, 2017

Choose a reason for hiding this comment

Uh oh!

janetkuo commented Jul 26, 2017

Uh oh!

dixudx commented Jul 26, 2017

Uh oh!

dixudx commented Jul 26, 2017

Uh oh!

bgrant0607 commented Aug 10, 2017

Uh oh!

dixudx commented Aug 11, 2017

Uh oh!

janetkuo commented Aug 11, 2017

Uh oh!

bgrant0607 commented Aug 11, 2017

Uh oh!

dixudx commented Aug 12, 2017

Uh oh!

janetkuo commented Aug 12, 2017

Uh oh!

janetkuo commented Aug 12, 2017

Uh oh!

dixudx commented Aug 12, 2017

Uh oh!

janetkuo commented Aug 14, 2017

Uh oh!

thockin commented Aug 14, 2017

Uh oh!

dixudx commented Aug 15, 2017

Uh oh!

thockin commented Aug 15, 2017

Uh oh!

k8s-github-robot commented Aug 15, 2017

Uh oh!

k8s-github-robot commented Aug 15, 2017

Uh oh!

k8s-github-robot commented Aug 15, 2017

Uh oh!

Uh oh!

dixudx commented Jul 23, 2017 •

edited

Loading

janetkuo commented Jul 25, 2017 •

edited

Loading