ScaleIO - Specify SDC GUID value via node label#50780
Conversation
|
Hi @vladimirvivien. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/ok-to-test |
|
@vladimirvivien: you can't request testing unless you are a kubernetes member. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This needs an associated issue and a |
|
/ok-to-test |
|
@vladimirvivien can you update the PR message (fix #) |
| // it attemps to fallback to using drv_cfg binary | ||
| func (c *sioClient) getGuid() (string, error) { | ||
| if c.sdcGuid == "" { | ||
| glog.Warning(log("sdc guid not set, falling back to using drv_cfg to get it")) |
There was a problem hiding this comment.
this is going to spam the log each time sdc is missing.
|
|
||
| // merge in Sdc Guid label value | ||
| if err := attachSdcGuid(v.plugin, configData); err != nil { | ||
| glog.Error(log("failed to retrieve sdc guid: %", err)) |
|
|
||
| // merge in Sdc Guid label value | ||
| if err := attachSdcGuid(v.plugin, configData); err != nil { | ||
| glog.Error(log("failed to retrieve sdc guid: %", err)) |
|
@vladimirvivien You should apply for org membership, too. |
|
re-assign to me for approval, if needed |
|
@thockin can i put you down as sponsor to join k8s membership ? |
|
@vladimirvivien squash and then lgtm |
|
/retest |
|
/assign @childsb |
|
/test pull-kubernetes-unit |
|
/assign @childsb |
|
/test pull-kubernetes-e2e-kops-aws |
|
/test pull-kubernetes-e2e-kops-aws |
3 similar comments
|
/test pull-kubernetes-e2e-kops-aws |
|
/test pull-kubernetes-e2e-kops-aws |
|
/test pull-kubernetes-e2e-kops-aws |
|
/assign |
|
@vladimirvivien, please fix one exec and I'll try to squeeze it into 1.8 |
|
@jsafrane @vladimirvivien because this didn't get proper approvals before the code freeze, we'll need a feature exception ASAP. That process is here: https://github.com/kubernetes/features/blob/master/EXCEPTIONS.md |
The commit allow ScaleIO volume plugin to read SDC GUID value as a node label. If binary drv_cfg is not installed, the plugin will still work properly. If node label not found, it defaults to drv_cfg if installed.
|
@jsafrane got distracted with the storm (irma). But I made the change you requested earlier. |
|
@jsafrane looking forward for a LGTM and approval. |
|
/lgtm @vladimirvivien go ahead and file for exception. This is a low risk and isolated change. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jdumars, saad-ali, vladimirvivien Associated issue: 51537 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Adding do-not-merge until exception is approved by 1.8 release team. |
|
Approved in today's burndown meeting |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
|
@vladimirvivien: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
This is a ScaleIO plugin volume PR to do the following:
scaleio.sdcGuidvalue for the SDC GUIDinstance IDThis enhancement allows the ScaleIO plugin to work properly even if the drv_cfg binary is not installed on the kubelet node.
Special Notes
Associated issue - #51537
Closes #51537