Show events when describing service accounts#51035
Conversation
Signed-off-by: Matt Rogers <[email protected]>
|
Hi @mrogers950. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
/approve no-issue
…On Tue, Aug 22, 2017 at 10:34 PM, Kubernetes Submit Queue < ***@***.***> wrote:
[APPROVALNOTIFIER] This PR is *NOT APPROVED*
This pull-request has been approved by: *mrogers950
<#51035#>*, *smarterclayton
<#51035 (comment)>*
*No associated issue*. Update pull-request body to add a reference to an
issue, or get approval with /approve no-issue
The full list of commands accepted by this bot can be found here
<https://github.com/kubernetes/test-infra/blob/master/commands.md>.
Needs approval from an approver in each of these OWNERS Files:
- pkg/printers/OWNERS
<https://github.com/kubernetes/kubernetes/blob/master/pkg/printers/OWNERS>
[smarterclayton]
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#51035 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABG_pxf4CTBwrKibm97CVHH-NpO-xF7Zks5sa4-3gaJpZM4O9qDt>
.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrogers950, smarterclayton Associated issue requirement bypassed by: smarterclayton The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/ok-to-test |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue (batch tested with PRs 51108, 51035, 50539, 51160, 50947) |
|
@mrogers950: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Any events associated with service accounts should appear in the describe output.
Which issue this PR fixes:
Special notes for your reviewer:
Release note: