Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Moved node condition filter into a predicates.#51117

Merged
k8s-github-robot merged 2 commits into
kubernetes:masterfrom
k82cn:k8s_50360_2
Aug 28, 2017
Merged

Moved node condition filter into a predicates.#51117
k8s-github-robot merged 2 commits into
kubernetes:masterfrom
k82cn:k8s_50360_2

Conversation

@k82cn
Copy link
Copy Markdown
Contributor

@k82cn k82cn commented Aug 22, 2017

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #50360

Release note:

A new predicates, named 'CheckNodeCondition', was added to replace node condition filter. 'NetworkUnavailable', 'OutOfDisk' and 'NotReady' maybe reported as a reason when failed to schedule pods.

@k82cn k82cn self-assigned this Aug 22, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2017
@k8s-github-robot k8s-github-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 22, 2017
@k82cn k82cn force-pushed the k8s_50360_2 branch 2 times, most recently from e41a9be to 00ada44 Compare August 25, 2017 09:33
@k82cn
Copy link
Copy Markdown
Contributor Author

k82cn commented Aug 25, 2017

/test pull-kubernetes-e2e-gke-gpu

@k82cn k82cn changed the title [WIP] Moved node condition filter into a predicates. Moved node condition filter into a predicates. Aug 26, 2017
@k82cn
Copy link
Copy Markdown
Contributor Author

k82cn commented Aug 26, 2017

/assign @bsalamat , @gmarek
/unassign

In gke-gpu, it enabled alpha features which included equal cache; when node condition updated, we need to refresh equal cache.

The gke-gpu was broken since yesterday, let's wait for e2e-gke-gpu recovered; and retest it :).

@k82cn
Copy link
Copy Markdown
Contributor Author

k82cn commented Aug 27, 2017

/test pull-kubernetes-e2e-gke-gpu

@k82cn
Copy link
Copy Markdown
Contributor Author

k82cn commented Aug 27, 2017

aha, it's green now !

/cc @bsalamat @gmarek

@bsalamat
Copy link
Copy Markdown
Member

bsalamat commented Aug 28, 2017

@k82cn So, this is the exact same PR as you sent earlier, and the fact that the gpu test is passing now is unrelated to this PR, right?

@k82cn
Copy link
Copy Markdown
Contributor Author

k82cn commented Aug 28, 2017

@bsalamat , the first commit is exactly same with previous one; the second commit fix the issue of GPU.

@gmarek
Copy link
Copy Markdown
Contributor

gmarek commented Aug 28, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2017
@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 28, 2017

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gmarek, k82cn

Associated issue: 50360

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 28, 2017

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link
Copy Markdown

k8s-github-robot commented Aug 28, 2017

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit daf591c into kubernetes:master Aug 28, 2017
@k82cn k82cn deleted the k8s_50360_2 branch August 28, 2017 08:34
@bsalamat
Copy link
Copy Markdown
Member

bsalamat commented Aug 29, 2017

A change of behavior that I am seeing after this PR is that the scheduler runs a bunch of predicates for the master node as well. I guess this is expected as the order of running the predicates is not defined, but it would be great if we could avoid running predicates for "unschedulable" nodes in order to improve performance.

@gmarek
Copy link
Copy Markdown
Contributor

gmarek commented Aug 30, 2017

+1. IIUC @yastij is working on ordering of predicates.

@k82cn k82cn mentioned this pull request Aug 30, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsalamat bsalamat Awaiting requested review from bsalamat

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@resouer resouer

@gmarek gmarek

@bsalamat bsalamat

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move node condition filter in scheduler.factory into a new predicates

6 participants

@k82cn @bsalamat @gmarek @k8s-github-robot @resouer @k8s-ci-robot