Codestin Search App

RenaudWasTaken · 2017-08-22T22:50:33Z

What this PR does / why we need it:

This PR bumps down the version of the vendored version of gRPC from v1.5.1 to v1.3.0
This is needed as part of the Device Plugin API where we expect client and server to use the Keep alive feature in order to detect an error.

Unfortunately I had to also bump the version of golang.org/x/text and golang.org/x/net.

Design document: Device Plugin Design Proposal community#695
PR tracking: kubernetes/features#368

Which issue this PR fixes: fixes #51099
Which was caused by my previous PR updating to 1.5.1

Special notes for your reviewer:
@vishh @jiayingz @shyamjvs

Release note:

Bumped gRPC to v1.3.0

k8s-ci-robot · 2017-08-22T22:50:46Z

Hi @RenaudWasTaken. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

shyamjvs · 2017-08-22T22:53:10Z

/ok-to-test

RenaudWasTaken · 2017-08-23T00:31:47Z

Forgot to update the staging Godeps that's done now

vishh · 2017-08-23T00:46:23Z

 		{
 			"ImportPath": "github.com/gogo/protobuf/gogoproto",
-			"Comment": "v0.4-3-gc0656edd",
+			"Comment": "v0.4-3-gc0656ed",


What version is this? Is there no official release tag that we can use?

I agree that this is something that should be addressed however I don't believe this is the scope of this PR as neither this or the previous one changed the commit number.

There is an actual release - https://github.com/gogo/protobuf/releases/tag/v0.4
I hope a similar release would be available for other dependencies.
I'd like to avoid vendoring in HEAD of dependencies.
@wojtek-t @shyamjvs since you are experts in this area, can you weigh in?

@vishh I'd like to avoid revendoring anything else than gRPC and it's dependecies (x/net and x/text).
I really think that doing so is outside the scope of this PR and would need to go through the whole re-testing on a 100 node cluster.

Let's keep the changes to the minimum to avoid breaking anything else :)

I'm no expert here, but I'm seeing quite some packages in the file that don't seem to be from standard releases (e.g docker/engine-api, coreos/pkg). Apparently even the go-restful pkg.
IMO allowing only releases could become a serious limitation wrt feature velocity (i.e. wait for an upstream release before using it in your feature).

cc @thockin - the godep god :)

RenaudWasTaken · 2017-08-23T02:37:54Z

@shyamjvs @wojtek-t @jbeda @lavalamp could you PTAL :) ?
All tests are passing and this should fix #51099 as per @xiang90's recommendations

xiang90 · 2017-08-23T02:57:08Z

@shyamjvs can you do a stress test on this branch to confirm everything is OK?

shyamjvs · 2017-08-23T08:37:08Z

@RenaudWasTaken I'll test it on 100-node cluster - Can you please rebase before that?

RenaudWasTaken · 2017-08-23T09:12:00Z

@shyamjvs should be good now :)

shyamjvs · 2017-08-23T10:04:36Z

I'm on it.

shyamjvs · 2017-08-23T10:24:13Z

/retest

shyamjvs · 2017-08-23T13:07:05Z

/lgtm

I tested it locally on 100-node cluster and it works now:

Ran 2 of 677 Specs in 2108.795 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 675 Skipped PASS

Ginkgo ran 1 suite in 35m9.89029736s
Test Suite Passed
2017/08/23 14:34:01 util.go:133: Step './hack/ginkgo-e2e.sh --ginkgo.focus=\[Feature:Performance\]' finished in 35m11.628136112s

shyamjvs · 2017-08-23T13:07:47Z

Thanks for fixing.
@wojtek-t Could you approve the PR?

shyamjvs · 2017-08-23T13:10:40Z

/retest

wojtek-t · 2017-08-23T13:19:07Z

/approve

shyamjvs · 2017-08-23T14:14:19Z

/retest

RenaudWasTaken · 2017-08-23T16:56:56Z

Forgot once again to run update-staging-godeps.sh...
The verify job should now succeed

shyamjvs · 2017-08-23T16:59:22Z

/lgtm

k8s-github-robot · 2017-08-23T17:00:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RenaudWasTaken, shyamjvs, wojtek-t

Associated issue: 695

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

~~OWNERS~~ [wojtek-t]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-08-24T11:28:53Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2017-08-24T11:38:02Z

Automatic merge from submit-queue (batch tested with PRs 51193, 51154, 42689, 51189, 51200)

k8s-ci-robot · 2017-08-24T12:15:37Z

@RenaudWasTaken: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-unit	`1daaeb3`	link	`/test pull-kubernetes-unit`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2017

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2017

k8s-github-robot assigned jbeda and lavalamp Aug 22, 2017

k8s-github-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 22, 2017

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 22, 2017

RenaudWasTaken mentioned this pull request Aug 22, 2017

Revert "Updated gRPC vendoring to support Keep Alive" #51109

Merged

RenaudWasTaken force-pushed the gRPC-updated-1-3-0 branch from 5c82eb0 to c56ec71 Compare August 23, 2017 00:31

vishh reviewed Aug 23, 2017

View reviewed changes

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 23, 2017

RenaudWasTaken force-pushed the gRPC-updated-1-3-0 branch from c56ec71 to 14450dd Compare August 23, 2017 09:11

k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 23, 2017

k8s-ci-robot assigned shyamjvs Aug 23, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2017

shyamjvs changed the title ~~Bumped gRPC down to version to 1.3.0~~ Bumped gRPC version to 1.3.0 Aug 23, 2017

Bumped gRPC version to 1.3.0

1daaeb3

RenaudWasTaken force-pushed the gRPC-updated-1-3-0 branch from 14450dd to 1daaeb3 Compare August 23, 2017 16:56

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2017

k8s-github-robot merged commit 5fb38a3 into kubernetes:master Aug 24, 2017

ixdy mentioned this pull request Aug 24, 2017

Always create vendor/BUILD in hack/update-bazel.sh #51229

Merged

RenaudWasTaken deleted the gRPC-updated-1-3-0 branch September 24, 2018 13:24

Conversation

RenaudWasTaken commented Aug 22, 2017

Uh oh!

k8s-ci-robot commented Aug 22, 2017

Uh oh!

shyamjvs commented Aug 22, 2017

Uh oh!

RenaudWasTaken commented Aug 23, 2017

Uh oh!

vishh Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

RenaudWasTaken Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

vishh Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

RenaudWasTaken Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

shyamjvs Aug 23, 2017

Choose a reason for hiding this comment

Uh oh!

RenaudWasTaken commented Aug 23, 2017

Uh oh!

xiang90 commented Aug 23, 2017

Uh oh!

shyamjvs commented Aug 23, 2017

Uh oh!

RenaudWasTaken commented Aug 23, 2017

Uh oh!

shyamjvs commented Aug 23, 2017

Uh oh!

shyamjvs commented Aug 23, 2017

Uh oh!

shyamjvs commented Aug 23, 2017

Uh oh!

shyamjvs commented Aug 23, 2017

Uh oh!

shyamjvs commented Aug 23, 2017

Uh oh!

wojtek-t commented Aug 23, 2017

Uh oh!

shyamjvs commented Aug 23, 2017

Uh oh!

RenaudWasTaken commented Aug 23, 2017

Uh oh!

shyamjvs commented Aug 23, 2017

Uh oh!

k8s-github-robot commented Aug 23, 2017

Uh oh!

k8s-github-robot commented Aug 24, 2017

Uh oh!

k8s-github-robot commented Aug 24, 2017

Uh oh!

k8s-ci-robot commented Aug 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

k8s-ci-robot commented Aug 24, 2017 •

edited

Loading