Codestin Search App

jpbetz · 2017-08-26T19:47:27Z

What this PR does / why we need it:

Make the currently hard coded 60 global request timeout in apiserver configurable via a --request-timeout command line flag.

This has impacted k8s users on slower internet connections, making clusters resources inaccessible once the data volume for requests exceeds what can be transmitted in 60 seconds (the current hard coded limit). By making the limit configurable, users are able to extend the limit to a duration appropriate to their connection speed.

Which issue this PR fixes

Fixes #51355

Special notes for your reviewer:

We plan to backport this to 1.6 and 1.7. To ease the backport work, we've kept this change to a minimum. After this PR we will submit an additional PR to rename --min-request-timeout to something that more clearly describes it's purpose, such as --long-running-request-timeout-min.

Release note:

Add --request-timeout to kube-apiserver to make global request timeout configurable.

k8s-ci-robot · 2017-08-26T19:47:34Z

Hi @jpbetz. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

jpbetz · 2017-08-26T19:49:36Z

/assign mml

CaoShuFeng · 2017-08-27T03:46:18Z

-	// If specified, requests will be allocated a random timeout between this value, and twice this value.
-	// Note that it is up to the request handlers to ignore or honor this timeout. In seconds.
+	// If specified, all requests except those which match the LongRunningFunc predicate will timeout
+	// after this duration. In seconds.


Do we need In seconds for type time.Duration?

Good catch! No, we don't. I'll remove.

mml · 2017-08-28T16:10:39Z

/lgtm

Thanks!

deads2k · 2017-08-28T18:35:46Z

 		"The maximum number of mutating requests in flight at a given time. When the server exceeds this, "+
 		"it rejects requests. Zero for no limit.")

+	fs.DurationVar(&s.RequestTimeout, "request-timeout", s.RequestTimeout, ""+


validate it as non-negative.

Thanks. I've added the validation check.

deads2k · 2017-08-28T18:36:29Z

I'm fine with it. @sttts any reservations?

…ds to be configured.

jpbetz · 2017-08-28T23:08:43Z

/retest

k8s-ci-robot · 2017-08-28T23:08:56Z

@jpbetz: you can't request testing unless you are a kubernetes member.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mml · 2017-08-28T23:19:55Z

/ok-to-test

mml · 2017-08-28T23:20:39Z

/lgtm

jpbetz · 2017-08-29T00:30:27Z

/retest

jpbetz · 2017-08-29T01:50:13Z

/retest

jpbetz · 2017-08-29T03:40:27Z

/retest

jpbetz · 2017-08-29T04:20:56Z

/retest

wojtek-t · 2017-08-29T06:11:33Z

/approve

k8s-github-robot · 2017-08-29T06:11:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, mml, wojtek-t

Associated issue: 51355

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these OWNERS Files:

~~cmd/kube-apiserver/OWNERS~~ [mml,wojtek-t]
~~pkg/kubeapiserver/OWNERS~~ [wojtek-t]
~~staging/src/k8s.io/apiserver/OWNERS~~ [wojtek-t]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-08-29T08:17:39Z

Automatic merge from submit-queue (batch tested with PRs 50932, 49610, 51312, 51415, 50705)

@jpbetz

Automatic merge from submit-queue (batch tested with PRs 51480, 49616, 50123, 50846, 50404) Add KUBE_APISERVER_REQUEST_TIMEOUT_SEC env var. Cluster startup support for the flag added by #51415. I won't merge until that PR merges. Bug: #51355 cc @jpbetz

…-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of #51415 upstream release 1.6 Cherrypick of #51415 **What this PR does / why we need it**: Backporting to support Kubernetes users with slower internet connections that need the ability to increase this timeout. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```

k8s-cherrypick-bot · 2017-09-12T00:47:15Z

Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

jpbetz · 2017-09-13T04:46:57Z

Created PR #52385 to merge this into 1.7.

…-upstream-release-1.7 Automatic merge from submit-queue Automated cherry pick of #51415 upstream release 1.7 Cherrypick of #51415 Manually resolved merge conflicts for this one. **What this PR does / why we need it**: Backporting to support Kubernetes users with slower internet connections that need the ability to increase this timeout.

k8s-cherrypick-bot · 2017-09-13T12:02:29Z

Commit found in the "release-1.7" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked.

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 26, 2017

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 26, 2017

k8s-github-robot assigned liggitt and dims Aug 26, 2017

k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 26, 2017

jpbetz mentioned this pull request Aug 26, 2017

apiserver should export global timeout as a flag #51355

Closed

k8s-ci-robot assigned mml Aug 26, 2017

CaoShuFeng reviewed Aug 27, 2017

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2017

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2017

deads2k reviewed Aug 28, 2017

View reviewed changes

Add --request-timeout to allow the global request timeout of 60 secon…

cb76475

…ds to be configured.

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 28, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2017

mml mentioned this pull request Aug 28, 2017

Add KUBE_APISERVER_REQUEST_TIMEOUT_SEC env var. #51480

Merged

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2017

k8s-github-robot merged commit 0b0b2a2 into kubernetes:master Aug 29, 2017

mml added the cherrypick-candidate label Aug 29, 2017

mml added this to the v1.6 milestone Aug 29, 2017

jpbetz mentioned this pull request Sep 11, 2017

Automated cherry pick of #51415 upstream release 1.6 #52314

Merged

k8s-cherrypick-bot removed the cherrypick-candidate label Sep 12, 2017

mml modified the milestones: v1.7, v1.6 Sep 12, 2017

mml added the cherrypick-candidate label Sep 12, 2017

jpbetz mentioned this pull request Sep 13, 2017

Automated cherry pick of #51415 upstream release 1.7 #52385

Merged

wojtek-t added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Sep 13, 2017

k8s-cherrypick-bot removed the cherrypick-candidate label Sep 13, 2017

calvinyv mentioned this pull request Oct 10, 2017

upgrade to 1.7.6 QingCloudAppcenter/kubernetes#20

Closed

abhay-krishna mentioned this pull request Sep 15, 2021

Add extra args to improve CIS Benchmark results aws/eks-anywhere#192

Merged

Conversation

jpbetz commented Aug 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

k8s-ci-robot commented Aug 26, 2017

Uh oh!

jpbetz commented Aug 26, 2017

Uh oh!

CaoShuFeng Aug 27, 2017

Choose a reason for hiding this comment

Uh oh!

jpbetz Aug 27, 2017

Choose a reason for hiding this comment

Uh oh!

mml commented Aug 28, 2017

Uh oh!

deads2k Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

jpbetz Aug 28, 2017

Choose a reason for hiding this comment

Uh oh!

deads2k commented Aug 28, 2017

Uh oh!

jpbetz commented Aug 28, 2017

Uh oh!

k8s-ci-robot commented Aug 28, 2017

Uh oh!

mml commented Aug 28, 2017

Uh oh!

mml commented Aug 28, 2017

Uh oh!

jpbetz commented Aug 29, 2017

Uh oh!

jpbetz commented Aug 29, 2017

Uh oh!

jpbetz commented Aug 29, 2017

Uh oh!

jpbetz commented Aug 29, 2017

Uh oh!

wojtek-t commented Aug 29, 2017

Uh oh!

k8s-github-robot commented Aug 29, 2017

Uh oh!

k8s-github-robot commented Aug 29, 2017

Uh oh!

k8s-cherrypick-bot commented Sep 12, 2017

Uh oh!

jpbetz commented Sep 13, 2017

Uh oh!

k8s-cherrypick-bot commented Sep 13, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

jpbetz commented Aug 26, 2017 •

edited

Loading